From f2bbc3f83e703d68661d43da0eb5f3c2cc1506b3 Mon Sep 17 00:00:00 2001 From: lambday Date: Sat, 20 Aug 2016 17:25:10 +0530 Subject: [PATCH] handle negative mmd values in max ratio kernel selection --- src/shogun/statistical_testing/internals/mmd/VarianceH1.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shogun/statistical_testing/internals/mmd/VarianceH1.h b/src/shogun/statistical_testing/internals/mmd/VarianceH1.h index 1cd7bf378eb..b46f0170e9f 100644 --- a/src/shogun/statistical_testing/internals/mmd/VarianceH1.h +++ b/src/shogun/statistical_testing/internals/mmd/VarianceH1.h @@ -233,6 +233,9 @@ struct VarianceH1 } auto var_est=compute_variance_estimate(); auto mmd_est=compute_mmd_job(kernel_functor); + // TODO comfirm the theory + if (mmd_est<0) + mmd_est=0; result[k]=var_est/CMath::sqrt(mmd_est+m_lambda); }