From fdac479aac844e368aa977caf0be7b87e5568230 Mon Sep 17 00:00:00 2001 From: Roman Votyakov Date: Fri, 24 May 2013 23:36:39 +0700 Subject: [PATCH] Removed unused fields from inference method classes --- src/shogun/regression/gp/ExactInferenceMethod.h | 10 ---------- src/shogun/regression/gp/FITCInferenceMethod.h | 8 -------- src/shogun/regression/gp/InferenceMethod.h | 11 ++--------- src/shogun/regression/gp/LaplacianInferenceMethod.h | 5 ----- 4 files changed, 2 insertions(+), 32 deletions(-) diff --git a/src/shogun/regression/gp/ExactInferenceMethod.h b/src/shogun/regression/gp/ExactInferenceMethod.h index 475d323ab23..f39e5dbd9f9 100644 --- a/src/shogun/regression/gp/ExactInferenceMethod.h +++ b/src/shogun/regression/gp/ExactInferenceMethod.h @@ -17,8 +17,6 @@ namespace shogun { -class CInferenceMethod; - /** @brief The Gaussian Exact Form Inference Method * * This inference method computes the Gaussian Method @@ -44,9 +42,7 @@ class CInferenceMethod; */ class CExactInferenceMethod: public CInferenceMethod { - public: - /** Default Constructor */ CExactInferenceMethod(); @@ -96,7 +92,6 @@ class CExactInferenceMethod: public CInferenceMethod */ virtual SGVector get_alpha(); - /** get Cholesky Decomposition Matrix * * @return Cholesky Decomposition of Matrix: @@ -167,16 +162,11 @@ class CExactInferenceMethod: public CInferenceMethod virtual void update_all(); private: - /** Check if members of object are valid * for inference */ void check_members(); - - /** Kernel matrix with noise */ - SGMatrix m_kern_with_noise; }; - } #endif // HAVE_EIGEN3 diff --git a/src/shogun/regression/gp/FITCInferenceMethod.h b/src/shogun/regression/gp/FITCInferenceMethod.h index 6dfdf744f85..44b8b1efeca 100644 --- a/src/shogun/regression/gp/FITCInferenceMethod.h +++ b/src/shogun/regression/gp/FITCInferenceMethod.h @@ -39,9 +39,7 @@ namespace shogun */ class CFITCInferenceMethod: public CInferenceMethod { - public: - /** Default Constructor*/ CFITCInferenceMethod(); @@ -93,7 +91,6 @@ class CFITCInferenceMethod: public CInferenceMethod */ virtual SGVector get_alpha(); - /** get Cholesky Decomposition Matrix * * @return Cholesky Decomposition of Matrix: @@ -168,15 +165,11 @@ class CFITCInferenceMethod: public CInferenceMethod void init(); private: - /** Check if members of object are valid * for inference */ void check_members(); - /*Kernel matrix with noise*/ - SGMatrix m_kern_with_noise; - /*noise of the latent variables*/ float64_t m_ind_noise; @@ -220,7 +213,6 @@ class CFITCInferenceMethod: public CInferenceMethod */ SGVector m_be; }; - } #endif // HAVE_EIGEN3 diff --git a/src/shogun/regression/gp/InferenceMethod.h b/src/shogun/regression/gp/InferenceMethod.h index cbe5968f0df..d931e94521c 100644 --- a/src/shogun/regression/gp/InferenceMethod.h +++ b/src/shogun/regression/gp/InferenceMethod.h @@ -31,9 +31,7 @@ namespace shogun */ class CInferenceMethod : public CDifferentiableFunction { - public: - /** Default Constructor * */ @@ -166,7 +164,7 @@ class CInferenceMethod : public CDifferentiableFunction * * @return likelihood */ - CLikelihoodModel* get_model() {SG_REF(m_model); return m_model; } + CLikelihoodModel* get_model() { SG_REF(m_model); return m_model; } /**set likelihood model * @@ -202,9 +200,7 @@ class CInferenceMethod : public CDifferentiableFunction return m_latent_features; } - protected: - /** Update alpha matrix */ virtual void update_alpha() {} @@ -221,7 +217,6 @@ class CInferenceMethod : public CDifferentiableFunction void init(); protected: - /**Covariance Function*/ CKernel* m_kernel; @@ -276,9 +271,7 @@ class CInferenceMethod : public CDifferentiableFunction /** Kernel matrix from latent features */ SGMatrix m_latent_matrix; - }; - } #endif /* HAVE_EIGEN3 */ -#endif /* CInferenceMethod_H_ */ +#endif /* CINFERENCEMETHOD_H_ */ diff --git a/src/shogun/regression/gp/LaplacianInferenceMethod.h b/src/shogun/regression/gp/LaplacianInferenceMethod.h index a5845b15566..2c797896da5 100644 --- a/src/shogun/regression/gp/LaplacianInferenceMethod.h +++ b/src/shogun/regression/gp/LaplacianInferenceMethod.h @@ -45,9 +45,7 @@ namespace shogun */ class CLaplacianInferenceMethod: public CInferenceMethod { - public: - /** Default Constructor*/ CLaplacianInferenceMethod(); @@ -97,7 +95,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod */ virtual SGVector get_alpha(); - /** get Cholesky Decomposition Matrix * * @return Cholesky Decomposition of Matrix: @@ -220,7 +217,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod void init(); private: - /** Check if members of object are valid * for inference */ @@ -271,7 +267,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod /*log likelihood*/ float64_t lp; }; - } #endif // HAVE_EIGEN3