New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce complexity of headers with d-pointers and "only declaration" rule #2564
Comments
I love this idea, but SWIG will not compile faster, see https://github.com/shogun-toolbox/shogun/wiki/SWIG-issues Many other things will improve through this though. |
@lisitsyn, why is it good not to use member variables w/o getters (and setters too, I guess) within the class where they are members? |
@iglesias I'd say it is more flexible |
I am not sure what flexible is here. Can you put an example, @lisitsyn? :-) |
why does this compile faster? |
Okay guys a few cases that come into my mind:
|
+1 from my side to all this |
It sounds pretty awesome! |
Thanks a lot for the nice description, @lisitsyn :-) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
obsolete |
I propose to change:
to a better looking (and faster compiling) variant:
It would involve massive refactoring so should be done once and fast. One thing that comes for free - in our code we will not use member variables w/o getters anymore (which is considered good).
Another advantage is that very likely SWIG will compile much faster.I think possible approach involves writing some script instead of doing it manually.
The text was updated successfully, but these errors were encountered: