Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parameter names in each SGObject class #5174

Conversation

jaskiratsingh2000
Copy link

Before this commit the parameter names within the SGObject Class were using SG_ADD(&class_member, "name", "parameter description"). and with this the problem was that when changing the registered name (in this case "name") results in issues everytime there was refactoring of the parameters name. Hence to address this issue the class should register a static constexpr std::string_view kParam = "name" that should be used to register the class name which resolve this problem.

Hence this Pull Request resolve this fix by committing the files within following folders as mentioned below

  • machine
  • clustering
  • converter
📁 shogun
├── 📁 src
        └──📁 shogun
               ├── 📁 machine
               ├── 📁 clustering
               └── 📁 converter

Feel free to suggest any changes required. Thanks! 😃

@stale
Copy link

stale bot commented Jan 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 16, 2022
@stale
Copy link

stale bot commented Jan 24, 2022

This issue is now being closed due to a lack of activity. Feel free to reopen it.

@stale stale bot closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant