Fixes parameter names in each SGObject class #5174
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the parameter names within the SGObject Class were using
SG_ADD(&class_member, "name", "parameter description").
and with this the problem was that when changing the registered name (in this case "name") results in issues everytime there was refactoring of the parameters name. Hence to address this issue the class should register astatic constexpr std::string_view kParam = "name"
that should be used to register the class name which resolve this problem.Hence this Pull Request resolve this fix by committing the files within following folders as mentioned below
Feel free to suggest any changes required. Thanks! 😃