Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about new conda-forge packages #3943

Merged
merged 3 commits into from Jul 22, 2017

Conversation

djsutherland
Copy link
Contributor

I wasn't sure where this should go in the list, so I put it at the top. :p Feel free to move lower if you think it should be lower.

I wasn't sure where this should go in the list, so I put it at the top. :p  Feel free to move lower if you think it should be lower.
@codecov
Copy link

codecov bot commented Jul 21, 2017

Codecov Report

Merging #3943 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3943      +/-   ##
===========================================
- Coverage    55.48%   55.48%   -0.01%     
===========================================
  Files         1441     1441              
  Lines       105084   105084              
===========================================
- Hits         58310    58309       -1     
- Misses       46774    46775       +1
Impacted Files Coverage Δ
...g/kernelselection/internals/OptimizationSolver.cpp 84.21% <0%> (-3.51%) ⬇️
src/shogun/optimization/liblinear/tron.cpp 87.32% <0%> (ø) ⬆️
src/shogun/distance/BrayCurtisDistance.cpp 100% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818fcbf...5dec463. Read the comment docs.

@@ -27,6 +28,13 @@ For other cases, we describe how to build Shogun from source code.

## Ready-to-install packages <a name="binaries"></a>

### Anaconda packages <a name="anaconda"></a>
The base shogun library and its Python interface are available through the conda package manager, via <a href="https://conda-forge.org">conda-forge</a>. To install both:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: We try to use single lines per sentence

@karlnapf
Copy link
Member

Fine from my side

@karlnapf
Copy link
Member

Actually, why don't you also add a thing to NEWS?

@djsutherland
Copy link
Contributor Author

@karlnapf Sure....where do I put it? Between 6.0.0 and 6.1.0?

@karlnapf
Copy link
Member

Just after the 6.1 line, like the cloud/windows/c++11 announcement back for 6.0

@vigsterkr
Copy link
Member

@dougalsutherland this is like the best thing since.... EVER! :) thank you sooooo much for your efforts!

@vigsterkr vigsterkr merged commit 91ee436 into shogun-toolbox:develop Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants