Add mpark variant to dependency as alternative of cxx17 variant #4290
Conversation
vinx13
changed the title
| SOURCE_DIR ${VARIANT_SOURCE_DIR} | ||
| GIT_REPOSITORY https://github.com/mpark/variant.git | ||
| GIT_SHALLOW 1 | ||
| GIT_TAG single-header |
vigsterkr
May 18, 2018
Member
this should be ${VARIANT_RELEASE_VERSION} no?
this should be ${VARIANT_RELEASE_VERSION} no?
vinx13
May 18, 2018
Author
Member
this is a branch for release, each version is a single directory
this is a branch for release, each version is a single directory
vigsterkr
May 18, 2018
Member
because unfortunately the branch HEAD will always contain the latest release, meaning you will always checkout the latest release which probably not going to be in future VARIANT_RELEASE_VERSION and it's a good idea in general to depend on a specific version of an external lib.
because unfortunately the branch HEAD will always contain the latest release, meaning you will always checkout the latest release which probably not going to be in future VARIANT_RELEASE_VERSION and it's a good idea in general to depend on a specific version of an external lib.
vinx13
May 18, 2018
Author
Member
install with provided cmakelist requires a higher version cmake than ours
https://github.com/mpark/variant/blob/29319715a1f0eb0980d380db8a2fda5af8d58feb/CMakeLists.txt#L8
install with provided cmakelist requires a higher version cmake than ours
https://github.com/mpark/variant/blob/29319715a1f0eb0980d380db8a2fda5af8d58feb/CMakeLists.txt#L8
vigsterkr
May 18, 2018
Member
mmmm i've just checked that branch, sorry i totally misunderstood the concept this... it's pretty weird to me having a branch totally different content than the base branch :)
mmmm i've just checked that branch, sorry i totally misunderstood the concept this... it's pretty weird to me having a branch totally different content than the base branch :)
vigsterkr
May 18, 2018
Member
ignore my comments above
ignore my comments above
|
@vinx13 i'll ping you when you should rebase this branch over the latest develop so we can get an actual good picture of the CI status... sorry it is my fault :( |
|
@vinx13 could you please rebase your branch over latest develop and push it so that this PR gets properly tested. thnx! |
No description provided.