-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebooks with factory and getter / setter #4292
Update notebooks with factory and getter / setter #4292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If nobody objects, Ill merge this @vigsterkr @vinx13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some minor code formatting errors, see:
https://travis-ci.org/shogun-toolbox/shogun/jobs/381273090#L727
plz address those and then we can merge it!
* Update KNN notebook * Update naive-bayes notebook * Update multiclass_reduction notebook * Update autoencoder notebook * Update classification notebook * Update LMNN notebook * Update neuralnets_digits notebook * Update Scene_classification notebook * Update rbms_dbns notebook * Update tree ensemble notebook * Update MMD notebook * Update gp notebook * Update MKL notebook * Updte multilabel structure notebook * Update variational_classifier notebook * Update binary denoising notebook * Update xval notebook * Update FGM notebook * Update hashed features notebook
continue from #4269 , update more Jupyter notebooks with feature factory, tag getter / setter