Skip to content

Update notebooks with factory and getter / setter#4292

Merged
karlnapf merged 20 commits into
shogun-toolbox:developfrom
vinx13:doc/update_notebooks-2
May 22, 2018
Merged

Update notebooks with factory and getter / setter#4292
karlnapf merged 20 commits into
shogun-toolbox:developfrom
vinx13:doc/update_notebooks-2

Conversation

@vinx13
Copy link
Copy Markdown
Member

@vinx13 vinx13 commented May 20, 2018

continue from #4269 , update more Jupyter notebooks with feature factory, tag getter / setter

Copy link
Copy Markdown
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlnapf
Copy link
Copy Markdown
Member

karlnapf commented May 21, 2018

If nobody objects, Ill merge this @vigsterkr @vinx13

@vigsterkr vigsterkr self-requested a review May 22, 2018 09:43
Copy link
Copy Markdown
Member

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some minor code formatting errors, see:
https://travis-ci.org/shogun-toolbox/shogun/jobs/381273090#L727

plz address those and then we can merge it!

@karlnapf karlnapf merged commit 72c23c1 into shogun-toolbox:develop May 22, 2018
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
* Update KNN notebook
* Update naive-bayes notebook
* Update multiclass_reduction notebook
* Update autoencoder notebook
* Update classification notebook
* Update LMNN notebook
* Update neuralnets_digits notebook
* Update Scene_classification notebook
* Update rbms_dbns notebook
* Update tree ensemble notebook
* Update MMD notebook
* Update gp notebook
* Update MKL notebook
* Updte multilabel structure notebook
* Update variational_classifier notebook
* Update binary denoising notebook
* Update xval notebook
* Update FGM notebook
* Update hashed features notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants