New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks with factory and getter / setter #4292

Merged
merged 20 commits into from May 22, 2018

Conversation

Projects
None yet
3 participants
@vinx13
Contributor

vinx13 commented May 20, 2018

continue from #4269 , update more Jupyter notebooks with feature factory, tag getter / setter

@karlnapf

LGTM

@karlnapf

This comment has been minimized.

Member

karlnapf commented May 21, 2018

If nobody objects, Ill merge this @vigsterkr @vinx13

@vigsterkr vigsterkr self-requested a review May 22, 2018

@vigsterkr

there are some minor code formatting errors, see:
https://travis-ci.org/shogun-toolbox/shogun/jobs/381273090#L727

plz address those and then we can merge it!

@karlnapf karlnapf merged commit 72c23c1 into shogun-toolbox:develop May 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment