Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks with factory and getter / setter #4292

Merged
merged 20 commits into from May 22, 2018

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented May 20, 2018

continue from #4269 , update more Jupyter notebooks with feature factory, tag getter / setter

Copy link
Member

@karlnapf karlnapf left a comment

LGTM

@karlnapf
Copy link
Member

@karlnapf karlnapf commented May 21, 2018

If nobody objects, Ill merge this @vigsterkr @vinx13

@vigsterkr vigsterkr self-requested a review May 22, 2018
Copy link
Member

@vigsterkr vigsterkr left a comment

there are some minor code formatting errors, see:
https://travis-ci.org/shogun-toolbox/shogun/jobs/381273090#L727

plz address those and then we can merge it!

@karlnapf karlnapf merged commit 72c23c1 into shogun-toolbox:develop May 22, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
ktiefe added a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
* Update KNN notebook
* Update naive-bayes notebook
* Update multiclass_reduction notebook
* Update autoencoder notebook
* Update classification notebook
* Update LMNN notebook
* Update neuralnets_digits notebook
* Update Scene_classification notebook
* Update rbms_dbns notebook
* Update tree ensemble notebook
* Update MMD notebook
* Update gp notebook
* Update MKL notebook
* Updte multilabel structure notebook
* Update variational_classifier notebook
* Update binary denoising notebook
* Update xval notebook
* Update FGM notebook
* Update hashed features notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants