Drop apply_preprocessor and preprocessors states in features #4316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigsterkr
reviewed
May 30, 2018
|
|
||
| features_train->add_preprocessor(preproc); | ||
| features_train->apply_preprocessor(); | ||
| features_train = |
Member
There was a problem hiding this comment.
i know that this does not come from this patch but in case of this unit test do we really need to have features_train to have CDenseFeatures<float64_t> type?
vinx13
force-pushed
the
feature/transformers
branch
from
c75b4b2 to
2bfc4b5
Compare
vinx13
force-pushed
the
feature/transformers
branch
from
2bfc4b5 to
336ab52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.