Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop apply_preprocessor and preprocessors states in features #4316

Merged

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented May 30, 2018

No description provided.

@@ -595,11 +595,13 @@ TEST_F(GaussianProcessClassification, apply_preprocessor_and_binary)
CRescaleFeatures* preproc=new CRescaleFeatures();
preproc->fit(features_train);

features_train->add_preprocessor(preproc);
features_train->apply_preprocessor();
features_train =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know that this does not come from this patch but in case of this unit test do we really need to have features_train to have CDenseFeatures<float64_t> type?

Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it

@vinx13 vinx13 closed this May 31, 2018
@vinx13 vinx13 reopened this May 31, 2018
@vigsterkr vigsterkr merged commit 1cc9b92 into shogun-toolbox:feature/transformers May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants