New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse transform in transformer #4326

Merged
merged 4 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@vinx13
Contributor

vinx13 commented Jun 4, 2018

No description provided.

@@ -5,7 +5,8 @@
*/
/* These functions return new Objects */
%newobject shogun::CTransformer::transform(CFeatures*);
%newobject shogun::CTransformer::transform(CFeatures*, bool inplace=true);
%newobject shogun::CTransformer::inverse_transform(CFeatures*, bool inplace=true);

This comment has been minimized.

@karlnapf

karlnapf Jun 4, 2018

Member

can we rename to inverse ... without transform ?

@karlnapf

Could you let me know some examples of where such a thing is used? Just curious ... can't think of any (apart from the ICA one, I see that ... )

@vigsterkr

This comment has been minimized.

Member

vigsterkr commented Jun 4, 2018

@karlnapf

This comment has been minimized.

Member

karlnapf commented Jun 4, 2018

I see they have that ... well, then it is probably useful. ... ;)

@vigsterkr

This comment has been minimized.

Member

vigsterkr commented Jun 4, 2018

@karlnapf

This comment has been minimized.

Member

karlnapf commented Jun 4, 2018

Ah yes of course!
@vinx13 hey what about a cookbook for that use case? :)

@vigsterkr vigsterkr merged commit 45162b6 into shogun-toolbox:feature/transformers Jun 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment