Add inverse transform in transformer #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Jun 4, 2018
| @@ -5,7 +5,8 @@ | |||
| */ | |||
|
|
|||
| /* These functions return new Objects */ | |||
| %newobject shogun::CTransformer::transform(CFeatures*); | |||
| %newobject shogun::CTransformer::transform(CFeatures*, bool inplace=true); | |||
| %newobject shogun::CTransformer::inverse_transform(CFeatures*, bool inplace=true); | |||
There was a problem hiding this comment.
can we rename to inverse ... without transform ?
karlnapf
reviewed
Jun 4, 2018
|
The idea here was about sklearnish approach
… On 4 Jun 2018, at 16:45, Heiko Strathmann ***@***.***> wrote:
@karlnapf commented on this pull request.
In src/interfaces/swig/Transformer.i:
> @@ -5,7 +5,8 @@
*/
/* These functions return new Objects */
-%newobject shogun::CTransformer::transform(CFeatures*);
+%newobject shogun::CTransformer::transform(CFeatures*, bool inplace=true);
+%newobject shogun::CTransformer::inverse_transform(CFeatures*, bool inplace=true);
can we rename to inverse ... without transform ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I see they have that ... well, then it is probably useful. ... ;) |
|
Min max scaled target (regression) for which u learn a model but then u wanna actually map back the prediction into the “original scale”
… On 4 Jun 2018, at 16:47, Heiko Strathmann ***@***.***> wrote:
@karlnapf commented on this pull request.
Could you let me know some examples of where such a thing is used? Just curious ... can't think of any (apart from the ICA one, I see that ... )
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ah yes of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.