Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow SGIO to throw custom exception types #4331
Conversation
This comment has been minimized.
This comment has been minimized.
|
How are those macros used? Could you write a unit test? |
vinx13
force-pushed the
vinx13:feature/sgio_throw
branch
from
27335ea
to
c811845
Jun 6, 2018
vinx13
added some commits
Jun 6, 2018
vinx13
force-pushed the
vinx13:feature/sgio_throw
branch
from
c811845
to
79d863b
Jun 6, 2018
vinx13
added some commits
Jun 7, 2018
vigsterkr
merged commit b7d2ff9
into
shogun-toolbox:feature/transformers
Jun 8, 2018
added a commit
that referenced
this pull request
Jun 8, 2018
added a commit
that referenced
this pull request
Jun 11, 2018
added a commit
that referenced
this pull request
Jun 28, 2018
added a commit
that referenced
this pull request
Jul 10, 2018
added a commit
that referenced
this pull request
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vinx13 commentedJun 6, 2018
REQUIRE_E,SG_THROW,SG_STHROWthat support using custom exception types