Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SGIO to throw custom exception types #4331

Merged

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Jun 6, 2018

  • separate formatting and printing in SGIO::message
  • define new macros REQUIRE_E, SG_THROW, SG_STHROW that support using custom exception types

@karlnapf
Copy link
Member

karlnapf commented Jun 6, 2018

How are those macros used? Could you write a unit test?

@vigsterkr vigsterkr merged commit b7d2ff9 into shogun-toolbox:feature/transformers Jun 8, 2018
vigsterkr pushed a commit that referenced this pull request Jun 8, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jun 11, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jun 28, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jul 10, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jul 12, 2018
Allow SGIO to throw custom exception types
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants