Allow SGIO to throw custom exception types #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are those macros used? Could you write a unit test? |
vinx13
force-pushed
the
feature/sgio_throw
branch
from
27335ea
to
c811845
Compare
vinx13
force-pushed
the
feature/sgio_throw
branch
from
c811845
to
79d863b
Compare
vigsterkr
pushed a commit
that referenced
this pull request
Jun 8, 2018
Allow SGIO to throw custom exception types
vigsterkr
pushed a commit
that referenced
this pull request
Jun 11, 2018
Allow SGIO to throw custom exception types
vigsterkr
pushed a commit
that referenced
this pull request
Jun 28, 2018
Allow SGIO to throw custom exception types
vigsterkr
pushed a commit
that referenced
this pull request
Jul 10, 2018
Allow SGIO to throw custom exception types
vigsterkr
pushed a commit
that referenced
this pull request
Jul 12, 2018
Allow SGIO to throw custom exception types
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Allow SGIO to throw custom exception types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REQUIRE_E,SG_THROW,SG_STHROWthat support using custom exception types