New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SGIO to throw custom exception types #4331

Merged
merged 4 commits into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@vinx13
Contributor

vinx13 commented Jun 6, 2018

  • separate formatting and printing in SGIO::message
  • define new macros REQUIRE_E, SG_THROW, SG_STHROW that support using custom exception types
@karlnapf

This comment has been minimized.

Member

karlnapf commented Jun 6, 2018

How are those macros used? Could you write a unit test?

@vinx13 vinx13 force-pushed the vinx13:feature/sgio_throw branch from 27335ea to c811845 Jun 6, 2018

@vinx13 vinx13 force-pushed the vinx13:feature/sgio_throw branch from c811845 to 79d863b Jun 6, 2018

vinx13 added some commits Jun 7, 2018

@vigsterkr vigsterkr merged commit b7d2ff9 into shogun-toolbox:feature/transformers Jun 8, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

vigsterkr added a commit that referenced this pull request Jun 8, 2018

Allow SGIO to throw custom exception types (#4331)
Allow SGIO to throw custom exception types

vigsterkr added a commit that referenced this pull request Jun 11, 2018

Allow SGIO to throw custom exception types (#4331)
Allow SGIO to throw custom exception types

vigsterkr added a commit that referenced this pull request Jun 28, 2018

Allow SGIO to throw custom exception types (#4331)
Allow SGIO to throw custom exception types

vigsterkr added a commit that referenced this pull request Jul 10, 2018

Allow SGIO to throw custom exception types (#4331)
Allow SGIO to throw custom exception types

vigsterkr added a commit that referenced this pull request Jul 12, 2018

Allow SGIO to throw custom exception types (#4331)
Allow SGIO to throw custom exception types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment