Skip to content

/ shogun

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SGIO to throw custom exception types #4331

Merged
merged 4 commits into from Jun 8, 2018
Merged

Allow SGIO to throw custom exception types #4331

merged 4 commits into from Jun 8, 2018

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jun 6, 2018

  • separate formatting and printing in SGIO::message
  • define new macros REQUIRE_E, SG_THROW, SG_STHROW that support using custom exception types
@karlnapf
Copy link
Member

@karlnapf karlnapf commented Jun 6, 2018

How are those macros used? Could you write a unit test?
@vinx13 vinx13 force-pushed the vinx13:feature/sgio_throw branch from 27335ea to c811845 Jun 6, 2018
vinx13 added 2 commits Jun 6, 2018
@vinx13
Allow SGIO to throw custom exception types
9c7ec6b
@vinx13
Add unittest
Loading status checks…
79d863b
@vinx13 vinx13 force-pushed the vinx13:feature/sgio_throw branch from c811845 to 79d863b Jun 6, 2018
vinx13 added 2 commits Jun 7, 2018
@vinx13
Use univ-reference in forwarding
Loading status checks…
2991c4a
@vinx13
Fix REQUIRE_E macro on msvc
Loading status checks…
3070dbc
@vigsterkr vigsterkr merged commit b7d2ff9 into shogun-toolbox:feature/transformers Jun 8, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
vigsterkr added a commit that referenced this pull request Jun 8, 2018
@vinx13 @vigsterkr
Allow SGIO to throw custom exception types (#4331)
Loading status checks…
f211b65 
Allow SGIO to throw custom exception types
vigsterkr added a commit that referenced this pull request Jun 11, 2018
@vinx13 @vigsterkr
Allow SGIO to throw custom exception types (#4331)
Loading status checks…
0fa4faa 
Allow SGIO to throw custom exception types
vigsterkr added a commit that referenced this pull request Jun 28, 2018
@vinx13 @vigsterkr
Allow SGIO to throw custom exception types (#4331)
6db7f9b 
Allow SGIO to throw custom exception types
vigsterkr added a commit that referenced this pull request Jul 10, 2018
@vinx13 @vigsterkr
Allow SGIO to throw custom exception types (#4331)
2270c00 
Allow SGIO to throw custom exception types
vigsterkr added a commit that referenced this pull request Jul 12, 2018
@vinx13 @vigsterkr
Allow SGIO to throw custom exception types (#4331)
9a45d79 
Allow SGIO to throw custom exception types
ktiefe added a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@vinx13 @ktiefe
Allow SGIO to throw custom exception types (shogun-toolbox#4331)
cb51098 
Allow SGIO to throw custom exception types
@samdbrice samdbrice added the Tag: GSoC label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tag: GSoC
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@vinx13 @karlnapf @vigsterkr @samdbrice