Skip to content

Allow SGIO to throw custom exception types - #4331

Merged
vigsterkr merged 4 commits into
shogun-toolbox:feature/transformersfrom
vinx13:feature/sgio_throw
Jun 8, 2018
Merged

Allow SGIO to throw custom exception types#4331
vigsterkr merged 4 commits into
shogun-toolbox:feature/transformersfrom
vinx13:feature/sgio_throw

Conversation

@vinx13

@vinx13 vinx13 commented Jun 6, 2018

Copy link
Copy Markdown
Member
  • separate formatting and printing in SGIO::message
  • define new macros REQUIRE_E, SG_THROW, SG_STHROW that support using custom exception types

@karlnapf

karlnapf commented Jun 6, 2018

Copy link
Copy Markdown
Member

How are those macros used? Could you write a unit test?

@vinx13
vinx13 force-pushed the feature/sgio_throw branch from 27335ea to c811845 Compare June 6, 2018 15:55
@vinx13
vinx13 force-pushed the feature/sgio_throw branch from c811845 to 79d863b Compare June 6, 2018 16:12
@vigsterkr
vigsterkr merged commit b7d2ff9 into shogun-toolbox:feature/transformers Jun 8, 2018
vigsterkr pushed a commit that referenced this pull request Jun 8, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jun 11, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jun 28, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jul 10, 2018
Allow SGIO to throw custom exception types
vigsterkr pushed a commit that referenced this pull request Jul 12, 2018
Allow SGIO to throw custom exception types
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants