Add string features factory #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Jun 25, 2018
| switch (primitive_type) | ||
| { | ||
| case PT_CHAR: | ||
| result = new CStringFeatures<char>(file, alpha); |
There was a problem hiding this comment.
wasnt the idea that we dont want a string_features factory, buy instead somehow deal with this inside the features factory?
There was a problem hiding this comment.
i tried features(file) to load a string features into a dense one, no error happens until you actually use the features in some algorithms.
There was a problem hiding this comment.
this is something that could be done in the factory, or? (taling a sneak preview)
|
Merging, as this allows us to continue adding more examples, and the |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.