New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string features factory #4345

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@vinx13
Contributor

vinx13 commented Jun 25, 2018

No description provided.

switch (primitive_type)
{
case PT_CHAR:
result = new CStringFeatures<char>(file, alpha);

This comment has been minimized.

@karlnapf

karlnapf Jun 25, 2018

Member

wasnt the idea that we dont want a string_features factory, buy instead somehow deal with this inside the features factory?

This comment has been minimized.

@vinx13

vinx13 Jun 26, 2018

Contributor

i tried features(file) to load a string features into a dense one, no error happens until you actually use the features in some algorithms.

This comment has been minimized.

@karlnapf

karlnapf Jul 3, 2018

Member

this is something that could be done in the factory, or? (taling a sneak preview)

@karlnapf karlnapf merged commit 31ed13b into shogun-toolbox:develop Jul 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@karlnapf

This comment has been minimized.

Member

karlnapf commented Jul 3, 2018

Merging, as this allows us to continue adding more examples, and the string_features factory can very easily be grep replaced later once there is an appropriate factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment