Add string features factory #4345
Merged
Conversation
switch (primitive_type) | ||
{ | ||
case PT_CHAR: | ||
result = new CStringFeatures<char>(file, alpha); |
karlnapf
Jun 25, 2018
Member
wasnt the idea that we dont want a string_features
factory, buy instead somehow deal with this inside the features
factory?
wasnt the idea that we dont want a string_features
factory, buy instead somehow deal with this inside the features
factory?
vinx13
Jun 26, 2018
Author
Member
i tried features(file)
to load a string features into a dense one, no error happens until you actually use the features in some algorithms.
i tried features(file)
to load a string features into a dense one, no error happens until you actually use the features in some algorithms.
karlnapf
Jul 3, 2018
Member
this is something that could be done in the factory, or? (taling a sneak preview)
this is something that could be done in the factory, or? (taling a sneak preview)
Merging, as this allows us to continue adding more examples, and the |
ktiefe
added a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.