Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd string features factory #4345
Conversation
| switch (primitive_type) | ||
| { | ||
| case PT_CHAR: | ||
| result = new CStringFeatures<char>(file, alpha); |
This comment has been minimized.
This comment has been minimized.
karlnapf
Jun 25, 2018
Member
wasnt the idea that we dont want a string_features factory, buy instead somehow deal with this inside the features factory?
This comment has been minimized.
This comment has been minimized.
vinx13
Jun 26, 2018
Contributor
i tried features(file) to load a string features into a dense one, no error happens until you actually use the features in some algorithms.
This comment has been minimized.
This comment has been minimized.
karlnapf
Jul 3, 2018
Member
this is something that could be done in the factory, or? (taling a sneak preview)
karlnapf
merged commit 31ed13b
into
shogun-toolbox:develop
Jul 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Merging, as this allows us to continue adding more examples, and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vinx13 commentedJun 25, 2018
No description provided.