Add factory of embed string features #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Jul 16, 2018
src/shogun/util/factory.h
Outdated
| @@ -106,6 +106,50 @@ namespace shogun | |||
| return result; | |||
| } | |||
|
|
|||
| /** Create embed string features from string char features | |||
karlnapf
reviewed
Jul 16, 2018
src/shogun/util/factory.h
Outdated
| @@ -106,6 +106,50 @@ namespace shogun | |||
| return result; | |||
| } | |||
|
|
|||
| /** Create embed string features from string char features | |||
There was a problem hiding this comment.
this is user facing doc, so you need to make it a bit more user friendly
karlnapf
reviewed
Jul 18, 2018
src/shogun/util/factory.h
Outdated
| /** Create embed string features from string char features | ||
| /** Create embedded string features from string char features. | ||
| * The new features has the same alphabet as the original features. Data of | ||
| * the new features is obtained by calling `obtain_from_char` with the given |
There was a problem hiding this comment.
Much better. One final thing, could you make doxygen link the class method here?
karlnapf
pushed a commit
to karlnapf/shogun
that referenced
this pull request
Jul 20, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add another string features factory that calls
obtain_from_charinternally to translate a string features to high order representation