Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory of embed string features #4375

Merged

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jul 16, 2018

add another string features factory that calls obtain_from_char internally to translate a string features to high order representation

@@ -106,6 +106,50 @@ namespace shogun
return result;
}

/** Create embed string features from string char features

This comment has been minimized.

@karlnapf

karlnapf Jul 16, 2018
Member

"embedded"

@@ -106,6 +106,50 @@ namespace shogun
return result;
}

/** Create embed string features from string char features

This comment has been minimized.

@karlnapf

karlnapf Jul 16, 2018
Member

this is user facing doc, so you need to make it a bit more user friendly

Copy link
Member

@karlnapf karlnapf left a comment

Good apart from those docs

/** Create embed string features from string char features
/** Create embedded string features from string char features.
* The new features has the same alphabet as the original features. Data of
* the new features is obtained by calling `obtain_from_char` with the given

This comment has been minimized.

@karlnapf

karlnapf Jul 18, 2018
Member

Much better. One final thing, could you make doxygen link the class method here?

@karlnapf karlnapf merged commit f8963c1 into shogun-toolbox:develop Jul 19, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
karlnapf added a commit to karlnapf/shogun that referenced this pull request Jul 20, 2018
ktiefe added a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@samdbrice samdbrice added the Tag: GSoC label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants