New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add factory of embed string features #4375
Add factory of embed string features #4375
Conversation
src/shogun/util/factory.h
Outdated
@@ -106,6 +106,50 @@ namespace shogun | |||
return result; | |||
} | |||
|
|||
/** Create embed string features from string char features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"embedded"
src/shogun/util/factory.h
Outdated
@@ -106,6 +106,50 @@ namespace shogun | |||
return result; | |||
} | |||
|
|||
/** Create embed string features from string char features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is user facing doc, so you need to make it a bit more user friendly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good apart from those docs
src/shogun/util/factory.h
Outdated
/** Create embed string features from string char features | ||
/** Create embedded string features from string char features. | ||
* The new features has the same alphabet as the original features. Data of | ||
* the new features is obtained by calling `obtain_from_char` with the given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. One final thing, could you make doxygen link the class method here?
add another string features factory that calls
obtain_from_char
internally to translate a string features to high order representation