Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd factory of embed string features #4375
Conversation
src/shogun/util/factory.h
Outdated
| @@ -106,6 +106,50 @@ namespace shogun | ||
| return result; | ||
| } | ||
| /** Create embed string features from string char features |
This comment has been minimized.
This comment has been minimized.
src/shogun/util/factory.h
Outdated
| @@ -106,6 +106,50 @@ namespace shogun | ||
| return result; | ||
| } | ||
| /** Create embed string features from string char features |
This comment has been minimized.
This comment has been minimized.
karlnapf
Jul 16, 2018
Member
this is user facing doc, so you need to make it a bit more user friendly
src/shogun/util/factory.h
Outdated
| /** Create embed string features from string char features | ||
| /** Create embedded string features from string char features. | ||
| * The new features has the same alphabet as the original features. Data of | ||
| * the new features is obtained by calling `obtain_from_char` with the given |
This comment has been minimized.
This comment has been minimized.
karlnapf
Jul 18, 2018
Member
Much better. One final thing, could you make doxygen link the class method here?
karlnapf
merged commit f8963c1
into
shogun-toolbox:develop
Jul 19, 2018
added a commit
to karlnapf/shogun
that referenced
this pull request
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vinx13 commentedJul 16, 2018
add another string features factory that calls
obtain_from_charinternally to translate a string features to high order representation