Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of set_feature_matrix #4376

Merged

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jul 17, 2018

now the only usage of set_feature_matrix is swig

$self->set_feature_matrix(new_feat_matrix.clone());

after that we can drop it from public api

@vinx13
Copy link
Member Author

@vinx13 vinx13 commented Aug 1, 2018

an idea to deal with swig is to use a friend function, so that we can hide set_feature_matrix from public api, @karlnapf what do you think

@karlnapf
Copy link
Member

@karlnapf karlnapf commented Aug 3, 2018

I think that is a good idea, depending on where this statement will be.
The alternative in such special cases is to use put<SGMatrix<T>>("feature_matrix", mat)

@vinx13 vinx13 force-pushed the vinx13:cleanup/drop_set_feature_matrix branch from 4e34014 to 1686180 Aug 6, 2018
@vigsterkr vigsterkr merged commit aab0812 into shogun-toolbox:develop Aug 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
ktiefe added a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
* Make set_feature_matrix protected
* Use put instead set_feature_matrix in swig
* Call tag-version put
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants