Drop usage of set_feature_matrix #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an idea to deal with swig is to use a friend function, so that we can hide |
|
I think that is a good idea, depending on where this statement will be. |
vinx13
force-pushed
the
cleanup/drop_set_feature_matrix
branch
from
4e34014
to
1686180
Compare
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
* Make set_feature_matrix protected * Use put instead set_feature_matrix in swig * Call tag-version put
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now the only usage of
set_feature_matrixis swigshogun/src/interfaces/python/DenseFeatures_protocols.i
Line 661 in 770f748
after that we can drop it from public api