Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport cross validation of pipeline #4377
Conversation
vinx13
changed the title from
made store_model_features public and implemented it in pipeline
to
Support cross validation of pipeline
Jul 17, 2018
vinx13
referenced this pull request
Jul 20, 2018
Open
Add cookbook of cross validation with pipeline #4380
vinx13
force-pushed the
vinx13:feature/pipeline_xval
branch
2 times, most recently
from
457aac1
to
f508903
Jul 23, 2018
| @@ -108,6 +108,11 @@ class CHierarchical : public CDistanceMachine | ||
| return false; | ||
| } | ||
| /** TODO: Ensures cluster centers are in lhs of underlying distance |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vinx13
Jul 31, 2018
•
Contributor
this comment was left before, i just copy-pasted to make the method public
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
couldnt we make some friend classes instead of adding the set_store_model features to the interface. This is not meant to be an interface method (definitely not for SWIG, but not even for cpp) |
| * and therefore the model anyway | ||
| */ | ||
| virtual void store_model_features(); | ||
| /** Computes the added bias. The bias is computed |
This comment has been minimized.
This comment has been minimized.
| void CPipeline::set_store_model_features(bool store_model) | ||
| { | ||
| get_machine()->set_store_model_features(store_model); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vinx13
Jul 31, 2018
Contributor
it's a protected method from base class, you cannot access it of another instance in the derived class CPipeline
This comment has been minimized.
This comment has been minimized.
| CSGObject* CPipeline::clone() | ||
| { | ||
| auto result = CMachine::clone()->as<CPipeline>(); | ||
| for (auto&& stage : m_stages) |
This comment has been minimized.
This comment has been minimized.
karlnapf
Jul 31, 2018
Member
I think we could probably do this via the parameter framework clone, with a few additions for std::types. The class is not serializable anyways.
@lisitsyn what do you think?
karlnapf
reviewed
Jul 31, 2018
LGTM, apart from this public method that should be at least hidden from swig, or better, not be public.
vinx13
force-pushed the
vinx13:feature/pipeline_xval
branch
2 times, most recently
from
767990c
to
1079fb9
Jul 31, 2018
vinx13
added some commits
Jul 17, 2018
vinx13
force-pushed the
vinx13:feature/pipeline_xval
branch
from
6a3187f
to
c4bbf8d
Aug 2, 2018
This comment has been minimized.
This comment has been minimized.
|
@vigsterkr could you check and merge this? |
vinx13 commentedJul 17, 2018
•
edited
store_model_featuresin pipeline, which forwards the call to the underlying machine of the pipeline* madestore_model_featurepublic, such that as a method of base classCMachineit is callable from pipelinecloneto make pipeline cloneableget_machine_problem_type