New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of inverse transform in ICAConverter cookbook #4390
Add description of inverse transform in ICAConverter cookbook #4390
Conversation
@@ -19,3 +19,7 @@ Features converted = ica.transform(feats) | |||
RealMatrix mixing_matrix = ica.get_real_matrix("mixing_matrix") | |||
RealMatrix unmixed_signal = converted.get_real_matrix("feature_matrix") | |||
#![extract] | |||
|
|||
#![inverse_transform] | |||
Features feats_original = ica.inverse_transform(converted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls also extract the matrix here (even if it is not shown in the cookbook) for the sake of integration testing ...
@@ -29,6 +29,9 @@ We can also extract the estimated mixing matrix. | |||
|
|||
.. sgexample:: independent_component_analysis_fast.sg:extract | |||
|
|||
:sgclass:`CICAConverter` supports inverse transformation. We can mix signals using the mixing matrix learnt before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: newline after period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a nice addition! thx
the data update is fishy |
Features feats_original = ica.inverse_transform(converted) | ||
#![inverse_transform] | ||
|
||
RealMatrix signal_original = feats_original.get_real_matrix("feature_matrix") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
something is still weird with the data |
@karlnapf i guess the data change of the old line now is because of float point precision error, they are very near |
No I mean all those removed files |
702f7e6
to
5582ce5
Compare
i rebased my data pr |
could you try again? |
5b7b738
to
681e5b5
Compare
@karlnapf tests passed |
No description provided.