Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd description of inverse transform in ICAConverter cookbook #4390
Conversation
| @@ -19,3 +19,7 @@ Features converted = ica.transform(feats) | ||
| RealMatrix mixing_matrix = ica.get_real_matrix("mixing_matrix") | ||
| RealMatrix unmixed_signal = converted.get_real_matrix("feature_matrix") | ||
| #![extract] | ||
| #![inverse_transform] | ||
| Features feats_original = ica.inverse_transform(converted) |
This comment has been minimized.
This comment has been minimized.
karlnapf
Aug 3, 2018
Member
pls also extract the matrix here (even if it is not shown in the cookbook) for the sake of integration testing ...
| @@ -29,6 +29,9 @@ We can also extract the estimated mixing matrix. | ||
| .. sgexample:: independent_component_analysis_fast.sg:extract | ||
| :sgclass:`CICAConverter` supports inverse transformation. We can mix signals using the mixing matrix learnt before. |
This comment has been minimized.
This comment has been minimized.
vinx13
referenced this pull request
Aug 3, 2018
Merged
Add integration data of ICAConverter inverse transformer #166
This comment has been minimized.
This comment has been minimized.
|
the data update is fishy |
| Features feats_original = ica.inverse_transform(converted) | ||
| #![inverse_transform] | ||
| RealMatrix signal_original = feats_original.get_real_matrix("feature_matrix") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
something is still weird with the data |
This comment has been minimized.
This comment has been minimized.
|
@karlnapf i guess the data change of the old line now is because of float point precision error, they are very near |
This comment has been minimized.
This comment has been minimized.
|
No I mean all those removed files |
vinx13
force-pushed the
vinx13:cookbook/inv_transform
branch
from
702f7e6
to
5582ce5
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
|
i rebased my data pr |
This comment has been minimized.
This comment has been minimized.
|
could you try again? |
vinx13
added some commits
Aug 2, 2018
vinx13
force-pushed the
vinx13:cookbook/inv_transform
branch
from
5b7b738
to
681e5b5
Aug 9, 2018
This comment has been minimized.
This comment has been minimized.
|
@karlnapf tests passed |
vigsterkr
merged commit c89317e
into
shogun-toolbox:develop
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vinx13 commentedAug 2, 2018
No description provided.