Add description of inverse transform in ICAConverter cookbook #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Aug 3, 2018
| @@ -19,3 +19,7 @@ Features converted = ica.transform(feats) | |||
| RealMatrix mixing_matrix = ica.get_real_matrix("mixing_matrix") | |||
| RealMatrix unmixed_signal = converted.get_real_matrix("feature_matrix") | |||
| #![extract] | |||
|
|
|||
| #![inverse_transform] | |||
| Features feats_original = ica.inverse_transform(converted) | |||
There was a problem hiding this comment.
pls also extract the matrix here (even if it is not shown in the cookbook) for the sake of integration testing ...
karlnapf
reviewed
Aug 3, 2018
| @@ -29,6 +29,9 @@ We can also extract the estimated mixing matrix. | |||
|
|
|||
| .. sgexample:: independent_component_analysis_fast.sg:extract | |||
|
|
|||
| :sgclass:`CICAConverter` supports inverse transformation. We can mix signals using the mixing matrix learnt before. | |||
|
the data update is fishy |
karlnapf
reviewed
Aug 3, 2018
| Features feats_original = ica.inverse_transform(converted) | ||
| #![inverse_transform] | ||
|
|
||
| RealMatrix signal_original = feats_original.get_real_matrix("feature_matrix") |
|
something is still weird with the data |
|
@karlnapf i guess the data change of the old line now is because of float point precision error, they are very near |
|
No I mean all those removed files |
vinx13
force-pushed
the
cookbook/inv_transform
branch
from
702f7e6 to
5582ce5
Compare
|
i rebased my data pr |
|
could you try again? |
vinx13
force-pushed
the
cookbook/inv_transform
branch
from
5b7b738 to
681e5b5
Compare
|
@karlnapf tests passed |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.