iPad and Android phone/tablet detection #17

Merged
merged 12 commits into from Apr 2, 2012

Conversation

Projects
None yet
3 participants
@srs81
Contributor

srs81 commented Mar 29, 2012

Added detection for iPad and Android phone/tablet.

srs81 and others added some commits Mar 29, 2012

@srs81

This comment has been minimized.

Show comment Hide comment
@srs81

srs81 Mar 29, 2012

Contributor

Thanks, I've fixed and added the unit tests appropriately, so it should be fine now.

Contributor

srs81 commented Mar 29, 2012

Thanks, I've fixed and added the unit tests appropriately, so it should be fine now.

@srs81

This comment has been minimized.

Show comment Hide comment
@srs81

srs81 Mar 29, 2012

Contributor

I've also added Blackberry phone and tablet detection, as well as unit tests for those. Sorry for all these commits coming in at once.

Contributor

srs81 commented Mar 29, 2012

I've also added Blackberry phone and tablet detection, as well as unit tests for those. Sorry for all these commits coming in at once.

shon added a commit that referenced this pull request Apr 2, 2012

Merge pull request #17 from srs81/master
iPad and Android phone/tablet detection

@shon shon merged commit 9b10fba into shon:master Apr 2, 2012

@shon

This comment has been minimized.

Show comment Hide comment
@shon

shon Apr 11, 2012

Owner

Hi Srs81/Suman,

I realized that we have "Phone" or "Tablet" in version now. For example for my phone running Android 2.3.5, version is detected as "Phone 2.3.5". I am not fully convinced by this. My opinion is Android version should always show up as 2.3.5 we should not include device type if it is not present in the version. I am reverting back deviceType detection code. Let me know if you don't agree.

Further, I think if you still need device type, we may have a new key "device_type" in detect result. One of us will have to add code accordingly. But we will delay documenting this device type detection.

Cheers.

Owner

shon commented Apr 11, 2012

Hi Srs81/Suman,

I realized that we have "Phone" or "Tablet" in version now. For example for my phone running Android 2.3.5, version is detected as "Phone 2.3.5". I am not fully convinced by this. My opinion is Android version should always show up as 2.3.5 we should not include device type if it is not present in the version. I am reverting back deviceType detection code. Let me know if you don't agree.

Further, I think if you still need device type, we may have a new key "device_type" in detect result. One of us will have to add code accordingly. But we will delay documenting this device type detection.

Cheers.

@srs81

This comment has been minimized.

Show comment Hide comment
@srs81

srs81 Apr 11, 2012

Contributor

Hi, makes sense. For my use, I actually do need to differentiate phone from tablet (and connected devices like Playstation, Google TV, etc), and that's why I added that code in, but maybe there are better ways to handle that. I'm open to whatever solution you come up with.

Contributor

srs81 commented Apr 11, 2012

Hi, makes sense. For my use, I actually do need to differentiate phone from tablet (and connected devices like Playstation, Google TV, etc), and that's why I added that code in, but maybe there are better ways to handle that. I'm open to whatever solution you come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment