New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN PR 2015 #7

merged 8 commits into from Mar 30, 2015


None yet
2 participants

fluca1978 commented Mar 27, 2015

During my CPAN Pull Request assignement I've found a few little cosmetic changes that can be applied to the module in order to improve readability (in my opinion).
I've tried to make a few little commits so that it is easier to pick every single change.

fluca1978 added some commits Mar 3, 2015

Compress version subroutine.
There is no need to extract method parameters since the module version
is returned as value.
Simplify the test against the func invocation.
There is no need to test the presence of the 'func' variable since it is
already checked against the ref function. Moreover, it is useless to
call scalar, since the array is already evaluated in a scalar context.
Simplify check in function ad_import.
There is no need to check for the undef value of $data, as well as it is
an hash with at least one key. The idea is to just test for $data being
an hash, and the following loop will not execute if there are no keys in
the hash (avoiding a keys invocation).
Simplify check for production configuration.
$app->mode is tested against the 'production' string, and to be more
readable the latter is the left operand.

shootnix added a commit that referenced this pull request Mar 30, 2015

@shootnix shootnix merged commit e17d20c into shootnix:master Mar 30, 2015


This comment has been minimized.


shootnix commented Mar 30, 2015

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment