From 6f8128bdd41532ce8c07c9826682f80cd6493267 Mon Sep 17 00:00:00 2001 From: SG-Noxoreos Date: Mon, 1 Apr 2019 18:21:21 +0200 Subject: [PATCH] PWA-1781: Updated changelog for PWA 6.4.0 release and removed a wrong JSDoc type comment in the swiper react component. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- CHANGELOG.md | 3 ++- libraries/common/components/Swiper/index.jsx | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b8133a0228..4282b923d8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,4 +15,4 @@ Please add an "x" into the option that is relevant: ## How to test it -Please describe here any specialty that the tester should be aware of. \ No newline at end of file +Please describe here any specialty that the tester should be aware of. diff --git a/CHANGELOG.md b/CHANGELOG.md index d49e117cc3..b179e56e1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ #### :rocket: Enhancement * [#589](https://github.com/shopgate/pwa/pull/589) The cart now display correct and consistent data in the totals. ([@devbucket](https://github.com/devbucket)) -* [#588](https://github.com/shopgate/pwa/pull/588) Add portals wrapping the view content ([@alexbridge](https://github.com/alexbridge)) +* [#588](https://github.com/shopgate/pwa/pull/588) Add portals wrapping the View Content ([@alexbridge](https://github.com/alexbridge)) * [#577](https://github.com/shopgate/pwa/pull/577) Implementation of the Barcode Scanner UI ([@fkloes](https://github.com/fkloes)) * [#573](https://github.com/shopgate/pwa/pull/573) Show QR Code Scan results ([@alexbridge](https://github.com/alexbridge)) * [#574](https://github.com/shopgate/pwa/pull/574) Unused selectors for UI and toast messages have been removed. ([@devbucket](https://github.com/devbucket)) @@ -14,6 +14,7 @@ * [#564](https://github.com/shopgate/pwa/pull/564) Restructured PaymentBar and added Portals around cart totals ([@fkloes](https://github.com/fkloes)) #### :bug: Bug Fix +* [#593](https://github.com/shopgate/pwa/pull/593) Fixed swiper open link actions ([@SG-Noxoreos](https://github.com/SG-Noxoreos)) * [#590](https://github.com/shopgate/pwa/pull/590) Patch for e2e tests for new slider implementation ([@alexbridge](https://github.com/alexbridge)) * [#571](https://github.com/shopgate/pwa/pull/571) Refactored the Sliders to use the new react-id-swiper version ([@devbucket](https://github.com/devbucket)) * [#576](https://github.com/shopgate/pwa/pull/576) Sentry.io level / severity is not send correctly ([@alexbridge](https://github.com/alexbridge)) diff --git a/libraries/common/components/Swiper/index.jsx b/libraries/common/components/Swiper/index.jsx index 41d70a5764..38f019041b 100644 --- a/libraries/common/components/Swiper/index.jsx +++ b/libraries/common/components/Swiper/index.jsx @@ -32,7 +32,6 @@ function Swiper(props) { disabled, } = props; - /** @type {Swiper} swiper An instance of the Swiper. */ const [swiper, setSwiper] = useState(null); useEffect(() => {