Skip to content
Permalink
Browse files Browse the repository at this point in the history
Merge pull request from GHSA-w8rc-pgxq-x2cj
Fixing negative charge vulnerability
  • Loading branch information
shopizer-ecommerce committed Apr 10, 2020
2 parents de8a8e3 + 6858049 commit 929ca08
Showing 1 changed file with 5 additions and 7 deletions.
Expand Up @@ -108,7 +108,7 @@ public ShoppingCartData addItemsToShoppingCart( final ShoppingCartData shoppingC
{

ShoppingCart cartModel = null;

if(item.getQuantity() < 1) item.setQuantity(1);
/**
* Sometimes a user logs in and a shopping cart is present in db (shoppingCartData
* but ui has no cookie with shopping cart code so the cart code will have
Expand Down Expand Up @@ -216,7 +216,7 @@ private com.salesmanager.core.model.shoppingcart.ShoppingCartItem createCartItem
}

for(ProductAvailability availability : availabilities) {
if(availability.getProductQuantity() == null || availability.getProductQuantity().intValue() ==0) {
if(availability.getProductQuantity() == null || availability.getProductQuantity().intValue() <= 0) {
throw new Exception( "Item with id " + product.getId() + " is not available");
}
}
Expand Down Expand Up @@ -288,7 +288,7 @@ private com.salesmanager.core.model.shoppingcart.ShoppingCartItem createCartItem
}

for(ProductAvailability availability : availabilities) {
if(availability.getProductQuantity() == null || availability.getProductQuantity().intValue() ==0) {
if(availability.getProductQuantity() == null || availability.getProductQuantity().intValue() <= 0) {
throw new Exception( "Item with id " + product.getId() + " is not available");
}
}
Expand Down Expand Up @@ -554,8 +554,7 @@ public ShoppingCartData updateCartItem( final Long itemID, final String cartId,
return null;
}

@SuppressWarnings("unchecked")
@Override
@Override
public ShoppingCartData updateCartItems( final List<ShoppingCartItem> shoppingCartItems, final MerchantStore store, final Language language )
throws Exception
{
Expand Down Expand Up @@ -720,7 +719,6 @@ public ReadableShoppingCart addToCart(PersistableShoppingCartItem item, Merchant
}


@SuppressWarnings("unchecked")
@Override
public void removeShoppingCartItem(String cartCode, Long productId,
MerchantStore merchant, Language language) throws Exception {
Expand Down Expand Up @@ -914,7 +912,7 @@ public ReadableShoppingCart addToCart(Customer customer, PersistableShoppingCart

Validate.notNull(customer,"Customer cannot be null");
Validate.notNull(customer.getId(),"Customer.id cannot be null or empty");

if(item.getQuantity() < 1) item.setQuantity(1);
//Check if customer has an existing shopping cart
ShoppingCart cartModel = shoppingCartService.getByCustomer(customer);

Expand Down

0 comments on commit 929ca08

Please sign in to comment.