Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] support all languages and collations #1004

Merged
merged 4 commits into from Jun 12, 2019
Merged

[shopsys] support all languages and collations #1004

merged 4 commits into from Jun 12, 2019

Conversation

@henzigo
Copy link
Member

henzigo commented May 7, 2019

Q A
Description, reason for the PR Framework supports only 6 languages. It was relatively difficult to add support for another language. This PR removes those restrictions and starts support all locales including Chinese or Russian language by default. You still have to adjust Demodata and tests.
New feature Yes
BC breaks Yes
Fixes issues closes #1003, closes #934
Standards and tests pass Yes/No
Have you read and signed our License Agreement for contributions? Yes

I didn't update upgrade notes, because I didn't know what I have to write there.

@henzigo henzigo force-pushed the jg-locale branch 3 times, most recently from 42b64b2 to c2df78f May 7, 2019
@henzigo henzigo marked this pull request as ready for review May 9, 2019
@henzigo henzigo force-pushed the jg-locale branch from c2df78f to 9858386 May 9, 2019
@boris-brtan boris-brtan force-pushed the jg-locale branch from 9858386 to 564c7db May 30, 2019
@boris-brtan

This comment has been minimized.

Copy link
Contributor

boris-brtan commented May 30, 2019

rebased onto new 8.0

@boris-brtan boris-brtan force-pushed the jg-locale branch 2 times, most recently from 85010b1 to 8b347d6 May 30, 2019
Copy link
Contributor

boris-brtan left a comment

Hi,
THX for this upgradefix, i just have a few suggestions. Would it be possible to name the commit messages more precisely?

@boris-brtan boris-brtan changed the title support all languages and collations [shopsys] support all languages and collations May 30, 2019
@boris-brtan boris-brtan requested a review from vitek-rostislav Jun 5, 2019
Copy link
Contributor

vitek-rostislav left a comment

Hi @henzigo, @boris-brtan, thanks for the simplification, it is great! I have reviewed it and found no issues in the code, I have just one question, in the diff, there are two files with no changes - routing_front_cs.yml and routing_front_en.yml - I do not even see any change of permissions so what does it mean? It can now go to tests 😉

Before merging the PR, we should extend the commit message where the ASCII transforming is fixed with the information about the broken transformation from Russian and Chinese

@boris-brtan

This comment has been minimized.

Copy link
Contributor

boris-brtan commented Jun 10, 2019

routing_front_cs.yml and routing_front_en.yml - I do not even see any change of permissions so what does it mean? It can now go to tests

if you check no white space changes it will write that there are only white space changes
maybe @henzigo got some strange phpstorm plugin for yamls

@vitek-rostislav

This comment has been minimized.

Copy link
Contributor

vitek-rostislav commented Jun 10, 2019

Oh, now I see these are new empty files in tests, my bad 🤦‍♂ 😄

@henzigo henzigo force-pushed the jg-locale branch from eb13902 to 62d1755 Jun 10, 2019
@boris-brtan boris-brtan force-pushed the jg-locale branch 2 times, most recently from 8b347d6 to 03d8478 Jun 10, 2019
@boris-brtan

This comment has been minimized.

Copy link
Contributor

boris-brtan commented Jun 10, 2019

TESTS seems ok also for zh(chinese), rebased on actual 8.0

Copy link
Contributor

LukasHeinz left a comment

Awesome job!

@boris-brtan boris-brtan force-pushed the jg-locale branch from 03d8478 to 6fff0cd Jun 12, 2019
@boris-brtan boris-brtan merged commit 02d9d8e into 8.0 Jun 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boris-brtan boris-brtan deleted the jg-locale branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.