Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coding-standards] all nullable values are now defined using nullability (?) symbol #1010

Merged
merged 1 commit into from May 21, 2019

Conversation

@TomasLudvik
Copy link
Member

TomasLudvik commented May 10, 2019

Q A
Description, reason for the PR Using non-question mark variation xxx(int $a = null) is wrong as is greatly explained in doctrine/common#805 (comment)
New feature Yes
BC breaks Yes
Fixes issues #994
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes
@TomasLudvik TomasLudvik force-pushed the tl-nullability branch from 2a4cbe2 to 40defd0 May 10, 2019
@TomasLudvik TomasLudvik force-pushed the tl-nullability branch 2 times, most recently from 01776b0 to 32529cb May 10, 2019
Copy link
Contributor

PetrHeinz left a comment

Nice PR 👍 You still have a change of whitespace in UPGRADE-unreleased.md so there are conflicts...

And please, rebase your branch onto 8.0 before merging so Travis can check the coding standards (whether there is no additional nullable param without explicit nullability).

@TomasLudvik TomasLudvik force-pushed the tl-nullability branch from 32529cb to 755d559 May 21, 2019
@TomasLudvik

This comment has been minimized.

Copy link
Member Author

TomasLudvik commented May 21, 2019

Hey @PetrHeinz, I have removed changes in UPGRADE-unreleased.md and rebased on 8.0

@TomasLudvik TomasLudvik force-pushed the tl-nullability branch from 755d559 to 7102196 May 21, 2019
Copy link
Contributor

PetrHeinz left a comment

Looking good 👍

@TomasLudvik TomasLudvik merged commit a130cc6 into 8.0 May 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boris-brtan boris-brtan deleted the tl-nullability branch May 29, 2019
@PetrHeinz PetrHeinz changed the title all nullable values are now defined using nullability (?) symbol [coding-standards] all nullable values are now defined using nullability (?) symbol Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.