Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] drop support for PHP 7.1 #1066

Merged
merged 6 commits into from Jun 5, 2019
Merged

[shopsys] drop support for PHP 7.1 #1066

merged 6 commits into from Jun 5, 2019

Conversation

@TomasLudvik
Copy link
Member

TomasLudvik commented May 24, 2019

Q A
Description, reason for the PR PHP 7.1 support will be terminated at the end of the year. There are known issues in versions before 7.1.3. Lot of packages no longer support PHP 7.1.
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes
@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch from 38c22d2 to 5aabf9e May 24, 2019
Copy link
Member

grossmannmartin left a comment

Hi, thanks for this 👍

package shopsys/http-smoke-testing stays on 7.0 on purpose? I don't mind if yes, but just wanted to know if it's a known decision.

I've noticed that in file open-source-license-acknowledgements-and-third-party-copyrights.md we have php image php:7.2-fpm-stretch (probably forgotten earlier). This should be 7.3 according to our Dockerfile. But maybe it's not mandatory in this PR.

In the documentation, there are still 7.1 versions as a minimum. This should be updated too.
application-requirements.md
installation-using-docker-linux.md
installation-using-docker-macos.md
installation-using-docker-windows-10-pro-higher.md

docs/upgrade/UPGRADE-v8.0.0.md Outdated Show resolved Hide resolved
@TomasLudvik

This comment has been minimized.

Copy link
Member Author

TomasLudvik commented May 24, 2019

Hello @grossmannmartin, thank you, I have really missed installation guide. All suggestion has been made.

@LukasHeinz

This comment has been minimized.

Copy link
Contributor

LukasHeinz commented May 24, 2019

When we stop spporting PHP 7.1. we can start using features of 7.2, right? I suggest we evaluate 7.2. features and consider what we want to use for Shopsys Framework. Interesting list is here - https://medium.com/@secmuhammed/php-7-2-new-features-fb7b8f88adb5

@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch from 107db64 to 8961486 May 27, 2019
@TomasLudvik

This comment has been minimized.

Copy link
Member Author

TomasLudvik commented May 27, 2019

When we stop spporting PHP 7.1. we can start using features of 7.2, right? I suggest we evaluate 7.2. features and consider what we want to use for Shopsys Framework. Interesting list is here - https://medium.com/@secmuhammed/php-7-2-new-features-fb7b8f88adb5

Hello @LukasHeinz, I have created new US in our backlog. The US is about adding support of parameter type widening in project-base.

@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch 4 times, most recently from 4b39c67 to d7fdf84 May 27, 2019
@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch 2 times, most recently from 8aa1328 to f9cfe0b May 27, 2019
@boris-brtan

This comment has been minimized.

Copy link
Contributor

boris-brtan commented May 30, 2019

hello @TomasLudvik you can rebase now and tests will be OK

TomasLudvik added 2 commits May 27, 2019
…rsion by all Shopsys packages

- some symfony packages versions has not been updated because they are no longer supported
- all packages are on travis build in PHP 7.2 and 7.3
@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch from f9cfe0b to e19f0e6 May 31, 2019
@TomasLudvik TomasLudvik force-pushed the tl-end-support-php-71 branch from e19f0e6 to c9e8edc May 31, 2019
composer.json Show resolved Hide resolved
project-base/composer.json Outdated Show resolved Hide resolved
project-base/composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

boris-brtan left a comment

hello please check the existence of all changed versions of packages via travis. monorepo and project-base installation.

…rted version by all Shopsys packages
@boris-brtan boris-brtan merged commit 2f3f873 into 8.0 Jun 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boris-brtan boris-brtan deleted the tl-end-support-php-71 branch Jun 5, 2019
@boris-brtan boris-brtan changed the title End support of PHP 7.1 [shopsys] drop support for PHP 7.1 Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.