Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] Registration of FriendlyUrlDataProviders is now done via service container #1140

Merged
merged 2 commits into from Jun 28, 2019

Conversation

@TomasLudvik
Copy link
Member

TomasLudvik commented Jun 18, 2019

Q A
Description, reason for the PR Symfony 3.4 came with way to autowire tagged services via service container. Registering of FriendlyUrlProviders was implemented the older way via CompilerPass. New implementation is much easier and clearer than before. Related to #1090.
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from 5489380 to 500467e Jun 18, 2019
@TomasLudvik TomasLudvik changed the base branch from master to 8.0 Jun 18, 2019
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch 6 times, most recently from 4e89723 to 9ffb0f4 Jun 18, 2019
Copy link
Contributor

vitek-rostislav left a comment

Hi @TomasLudvik - great job there, I really appreciate the simplification and new docs! Could you please also add a new entry into our FAQ article? Something like "How can I create a friendly URL for my entity?" and link your article there.

I have a few suggestions and notes, please check them out 😉

docs/upgrade/UPGRADE-v8.0.0.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/upgrade/UPGRADE-v8.0.0.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from c3dc1ba to 79de76b Jun 27, 2019
Copy link
Contributor

vitek-rostislav left a comment

Hi, the build is failing 🙁 https://travis-ci.org/shopsys/shopsys/jobs/551356622

Also, you have not added the entry to FAQ section, could you please do that?

docs/upgrade/UPGRADE-v8.0.0.md Outdated Show resolved Hide resolved
docs/upgrade/UPGRADE-v8.0.0.md Outdated Show resolved Hide resolved
@TomasLudvik

This comment has been minimized.

Copy link
Member Author

TomasLudvik commented Jun 27, 2019

Hi, the build is failing 🙁 https://travis-ci.org/shopsys/shopsys/jobs/551356622

Also, you have not added the entry to FAQ section, could you please do that?

FAQ section has been added, build I hope fixed - waiting for another one

Copy link
Contributor

vitek-rostislav left a comment

Hi, just a few suggestions

docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
docs/introduction/friendly-url.md Outdated Show resolved Hide resolved
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from 5af802d to 76736e3 Jun 27, 2019
Copy link
Contributor

vitek-rostislav left a comment

Reviewed and tested ✔️

@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from eef6a2d to c943c53 Jun 28, 2019
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from 8514cbd to 6ac60d1 Jun 28, 2019
TomasLudvik added 2 commits Jun 18, 2019
…riendly_url_provider' when they implement FriendlyUrlDataProviderInterface
…iner

- documentation about friendly url has been added
@TomasLudvik TomasLudvik force-pushed the tl-automatic-url-provider branch from 6ac60d1 to 524dffd Jun 28, 2019
@TomasLudvik TomasLudvik merged commit 439a4e2 into 8.0 Jun 28, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@TomasLudvik TomasLudvik deleted the tl-automatic-url-provider branch Jun 28, 2019
@PetrHeinz PetrHeinz changed the title [shopsys] Registration of FriendlyUrlDataProviders is now done via service container [framework] Registration of FriendlyUrlDataProviders is now done via service container Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.