Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coding-standards] explicit visibility is part of the general coding-standards #1254

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@PetrHeinz
Copy link
Contributor

PetrHeinz commented Jul 26, 2019

Q A
Description, reason for the PR Having explicit visibility for const, method, and property is now required even in project repositories. It leads to clearer code which will help our users and there is an automatic fixer for it, so it will not require extra work from them.
New feature Yes
BC breaks Not sure, actually
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes
@PetrHeinz PetrHeinz requested a review from vitek-rostislav Jul 26, 2019
Copy link
Contributor

vitek-rostislav left a comment

Hi, nice 👍 I was expecting some changes in the code of project-base, but if I remember correctly, we fixed all the violations when the fixer was implemented originally and then just turned off the fixer for project-base, right? 🙂

@PetrHeinz

This comment has been minimized.

Copy link
Contributor Author

PetrHeinz commented Jul 26, 2019

@vitek-rostislav Exactly - in #904 🙂

@PetrHeinz PetrHeinz merged commit 3c45ee5 into master Jul 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PetrHeinz PetrHeinz deleted the ph-explicit-visibility branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.