Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coding-standards] added return type hint spacing fixer #1255

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@PetrHeinz
Copy link
Contributor

PetrHeinz commented Jul 26, 2019

Q A
Description, reason for the PR Having a standard way of writing return type hints (): int) makes work easier for developers. It leads to more consistent code which will help our users and there is an automatic fixer for it, so it will not require extra work from them.
New feature Yes
BC breaks Not sure, actually
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes
@PetrHeinz PetrHeinz requested a review from vitek-rostislav Jul 26, 2019
Copy link
Contributor

vitek-rostislav left a comment

Nice 👌

  • Reviewed ✔️
  • Tested ✔️
@PetrHeinz PetrHeinz force-pushed the ph-return-type-spacing branch from 21ed0e7 to dc0ce9e Jul 26, 2019
@PetrHeinz PetrHeinz merged commit c65591d into master Jul 26, 2019
@PetrHeinz PetrHeinz deleted the ph-return-type-spacing branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.