Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-base] enforce strict typing in project repository #1256

Merged
merged 4 commits into from Jul 26, 2019

Conversation

@PetrHeinz
Copy link
Contributor

PetrHeinz commented Jul 26, 2019

Q A
Description, reason for the PR Using strict typing is a general best-practice in PHP. It leads to safer code which will help our users and there is an automatic fixer for it, so it will not require extra work from them, except for fixing wrongly typed variables.
Even though there is a lot to do for complete switch to strict typing across the whole codebase (there are few problems in our typing and the change could have serious backward-compatibility implications), we can recommend our users to enable the declare(strict_types=1) in their project.
New feature Yes
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes
@PetrHeinz PetrHeinz requested a review from vitek-rostislav Jul 26, 2019
@PetrHeinz PetrHeinz force-pushed the ph-strict-types branch 2 times, most recently from cd6db82 to e038318 Jul 26, 2019
Copy link
Contributor

vitek-rostislav left a comment

reviewed and tested, everything ok, just one note that has been already addressed during the review 👌

easy-coding-standard.yml Outdated Show resolved Hide resolved
@vitek-rostislav vitek-rostislav force-pushed the ph-strict-types branch from 4b7b4e8 to 7473e27 Jul 26, 2019
@vitek-rostislav vitek-rostislav merged commit 6cf4f7c into master Jul 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitek-rostislav vitek-rostislav deleted the ph-strict-types branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.