Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] fixed window fix bar in development mode #1632

Merged
merged 1 commit into from Jan 30, 2020

Conversation

pesektomas
Copy link
Contributor

Q A
Description, reason for the PR When I have enable development mode and have active symfony tool bar I don't see full window-fixed-bar element with action buttons in admin (on product detail page I don't see button for save changes). However when I hide/show symfony tool bar, window-fixed-bar element is moved. We moved window-fixed-bar element after page is loaded (and when symfony toolbar is enable)
New feature No
BC breaks No
Fixes issues closes #1631
Have you read and signed our License Agreement for contributions? Yes

@pesektomas pesektomas force-pushed the tp-fix-window-fixed-bar-in-dev-mode branch from 86ec5fd to 6c992b7 Compare January 30, 2020 09:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@s3tezsky s3tezsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@pesektomas pesektomas merged commit f4c0ae1 into master Jan 30, 2020
@pesektomas pesektomas deleted the tp-fix-window-fixed-bar-in-dev-mode branch February 13, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin : The action button is hidden behind the symfony debug bar.
4 participants