Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] logo on homepage is link and is not wrapped in H1 #2048

Merged
merged 1 commit into from Feb 23, 2021
Merged

[project-base] logo on homepage is link and is not wrapped in H1 #2048

merged 1 commit into from Feb 23, 2021

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Sep 24, 2020 •
edited by sslt

Q A
Description, reason for the PR Linked logo on homepage is consistent with the rest of the web, removed unnecessary code, and just image inside H1 has no semantic information so H1 wrapper is removed from logo allowing the H1 to be included in the content
New feature No
BC breaks No
Fixes issues ... closes #2243
Have you read and signed our License Agreement for contributions? Yes

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TomasLudvik
Copy link
Member

I am afraid of SEO impacts. Can you find some resource that says your solution is not a problem?

@TomasLudvik TomasLudvik added the Design & Appearance Issues connected to design, CSS or UX label Oct 16, 2020
@grossmannmartin grossmannmartin mentioned this pull request Feb 15, 2021
Closed
@sslt sslt changed the title [project-base] logo on homepage is link [project-base] logo on homepage is link and is not wrapped in H1 Feb 22, 2021
@grossmannmartin grossmannmartin changed the base branch from master to 9.1 February 23, 2021 08:19
@grossmannmartin grossmannmartin added this to the SSFW 9.1.1 milestone Feb 23, 2021
@grossmannmartin
Copy link
Member Author

I am afraid of SEO impacts. Can you find some resource that says your solution is not a problem?

We consulted it with SEO guys and they said it's ok if the page links to itself.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grossmannmartin grossmannmartin merged commit 4fca793 into 9.1 Feb 23, 2021
@grossmannmartin grossmannmartin deleted the mg-add-homepage-logo-link branch February 23, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@sslt sslt sslt approved these changes

@s3tezsky s3tezsky s3tezsky approved these changes

Assignees
No one assigned
Labels
Design & Appearance Issues connected to design, CSS or UX
Projects
None yet
Milestone
SSFW 9.1.1
Development

Successfully merging this pull request may close these issues.

H1 title in the logo is unnecessary
4 participants
@grossmannmartin @TomasLudvik @sslt @s3tezsky