[shopsys] added missing data to Product frontend API type #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Oct 1, 2020
TomasLudvik
commented
| Q | A |
|---|---|
| Description, reason for the PR | Some data of Product has been missing in frontend API, these has been added by this PR. |
| New feature | Yes |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
force-pushed
the
tl-product-additional-data
branch
2 times, most recently
from
badaf04
to
5f0788a
Compare
s3tezsky
suggested changes
Oct 5, 2020
packages/framework/src/Model/Product/Accessory/ProductAccessoryFacade.php
Outdated
Show resolved
Hide resolved
project-base/tests/FrontendApiBundle/Functional/Product/ProductTest.php
Outdated
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
tl-product-additional-data
branch
from
5f0788a
to
dbe3745
Compare
s3tezsky
reviewed
Oct 6, 2020
packages/framework/src/Model/Product/Accessory/ProductAccessoryFacade.php
Outdated
Show resolved
Hide resolved
s3tezsky
reviewed
Oct 7, 2020
packages/frontend-api/src/Model/Parameter/ParameterWithValuesFactory.php
Outdated
Show resolved
Hide resolved
s3tezsky
reviewed
Oct 7, 2020
packages/frontend-api/src/Model/Resolver/Parameter/ParameterResolverMap.php
Outdated
Show resolved
Hide resolved
s3tezsky
reviewed
Oct 7, 2020
packages/frontend-api/src/Model/Resolver/Products/ProductResolverMap.php
Outdated
Show resolved
Hide resolved
|
Great work! I left last few details, please check them out and fix travis build. Then it will be perfect 👌 |
s3tezsky
reviewed
Oct 8, 2020
TomasLudvik
added
the
Enhancement
s3tezsky
approved these changes
Oct 8, 2020
sslt
approved these changes
Oct 8, 2020
TomasLudvik
force-pushed
the
tl-product-additional-data
branch
from
3d6d11c
to
dfa08a9
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.