Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] admin: fixed displaying remove button for urls #2176

Merged
merged 1 commit into from Jan 11, 2021
Merged

[framework] admin: fixed displaying remove button for urls #2176

merged 1 commit into from Jan 11, 2021

Conversation

TomasLudvik
Copy link
Member

@TomasLudvik TomasLudvik commented Jan 7, 2021 •
edited

Q A
Description, reason for the PR There was error that main url radio button was not checked by default. This caused connected JS to stop function and that was reason why there was remove button next to the main URL instead of info icon with text, that main URL cannot be removed.
New feature No
BC breaks No
Fixes issues closes #2034
Have you read and signed our License Agreement for contributions? Yes

@TomasLudvik TomasLudvik added the Bug Something isn't working label Jan 7, 2021
@TomasLudvik TomasLudvik added this to the SSFW 9.1.1 milestone Jan 7, 2021
@TomasLudvik TomasLudvik force-pushed the tl-fix-main-url-delete-button branch 2 times, most recently from c89fa00 to a5c7108 Compare January 11, 2021 06:49
@TomasLudvik TomasLudvik changed the base branch from master to 9.1 January 11, 2021 06:49
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TomasLudvik TomasLudvik merged commit 99486f3 into 9.1 Jan 11, 2021
@TomasLudvik TomasLudvik deleted the tl-fix-main-url-delete-button branch January 11, 2021 08:00
@grossmannmartin grossmannmartin mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslt sslt sslt approved these changes

@s3tezsky s3tezsky s3tezsky approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
SSFW 9.1.1
Development

Successfully merging this pull request may close these issues.

Product main URL show delete icon even though it can't be deleted
3 participants
@TomasLudvik @sslt @s3tezsky