[shopsys] ckeditor is now inicialized after click #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
grossmannmartin
commented
Jan 8, 2021
•
grossmannmartin
commented
| Q | A |
|---|---|
| Description, reason for the PR | Rendering of CKEditor can slow down page load. Now the CKEditor is initialized after click to the appropriate field. Also, the field preview is rendered in admin when CKEditor is not initialized |
| New feature | No |
| BC breaks | No |
| Fixes issues | closes #1852 |
| Have you read and signed our License Agreement for contributions? | Yes |
grossmannmartin
force-pushed
the
mg-ckeditor-lazy-initialization
branch
4 times, most recently
from
84f9076
to
3ffc123
Compare
grossmannmartin
force-pushed
the
mg-ckeditor-lazy-initialization
branch
from
3ffc123
to
01f84df
Compare
TomasLudvik
requested changes
Jan 12, 2021
packages/framework/assets/js/admin/components/CkEditorPreview.js
Outdated
Show resolved
Hide resolved
packages/framework/assets/js/admin/components/CkEditorPreview.js
Outdated
Show resolved
Hide resolved
packages/framework/assets/js/admin/components/CkEditorPreview.js
Outdated
Show resolved
Hide resolved
packages/framework/src/Component/CkEditor/CkEditorRendererDecorator.php
Outdated
Show resolved
Hide resolved
packages/framework/assets/js/admin/components/CkEditorPreview.js
Outdated
Show resolved
Hide resolved
grossmannmartin
force-pushed
the
mg-ckeditor-lazy-initialization
branch
2 times, most recently
from
cb5a836
to
c2437f1
Compare
Srnka392
force-pushed
the
mg-ckeditor-lazy-initialization
branch
from
f0d739a
to
32280a4
Compare
TomasLudvik
approved these changes
Feb 15, 2021
Srnka392
force-pushed
the
mg-ckeditor-lazy-initialization
branch
from
32280a4
to
4f91ccb
Compare
sslt
approved these changes
Feb 16, 2021
s3tezsky
force-pushed
the
mg-ckeditor-lazy-initialization
branch
from
4f91ccb
to
5b79eb4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.