[shopsys] acceptance tests now use test prefix for css classes #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Jan 11, 2021
TomasLudvik
commented
| Q | A |
|---|---|
| Description, reason for the PR | This PR adds last improvement for acceptance tests and it is test prefix for CSS classes used for acceptance tests and new documentation with best practices to write acceptance tests. |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
added
Enhancement
TomasLudvik
force-pushed
the
tl-improve-acceptance-tests
branch
3 times, most recently
from
c86e3da
to
bc0f6ff
Compare
grossmannmartin
requested changes
Jan 14, 2021
There was a problem hiding this comment.
I wonder whether this should be part of the patch release...
Personally, I would prefer to change the milestone to 9.2 for two reasons.
- It's not a bugfix, but enhancement from my point of view.
- Upgrade to this need a lot of work without any added value for already running project (it's great in the implementation phase, though)
packages/framework/assets/js/admin/components/GridInlineEdit.js
Outdated
Show resolved
Hide resolved
project-base/tests/App/Test/Codeception/Module/StrictWebDriver.php
Outdated
Show resolved
Hide resolved
grossmannmartin
requested changes
Jan 15, 2021
TomasLudvik
force-pushed
the
tl-improve-acceptance-tests
branch
from
fcb7aca
to
d0fff7e
Compare
sslt
approved these changes
Jan 18, 2021
TomasLudvik
force-pushed
the
tl-improve-acceptance-tests
branch
from
d0fff7e
to
e30bfbc
Compare
… instead of js prefix - js-validation-error-list has not been changed because this classes are generated in forms for every single form element
…ernal - we do not intend to remove them as theirs purpose is to force developers to use other methods instead
TomasLudvik
force-pushed
the
tl-improve-acceptance-tests
branch
from
e30bfbc
to
57a1994
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.