Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend-api] Payment price is required #2201

Merged
merged 1 commit into from Feb 2, 2021
Merged

[frontend-api] Payment price is required #2201

merged 1 commit into from Feb 2, 2021

Conversation

stanoMilan
Copy link
Contributor

@stanoMilan stanoMilan commented Jan 21, 2021 •
edited by TomasLudvik

Q A
Description, reason for the PR Payment price must be required because Shopsys\FrontendApiBundle\Model\Resolver\Price::resolveByPayment always returns object of \Shopsys\FrameworkBundle\Model\Pricing\Price
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@sslt sslt added Bug Something isn't working Easy Pick Not tricky or complex issue labels Jan 22, 2021
@sslt sslt added this to the SSFW 9.1.1 milestone Jan 22, 2021
@TomasLudvik TomasLudvik changed the title Payment price is required [frontend-api] Payment price is required Jan 27, 2021
TomasLudvik
TomasLudvik approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@TomasLudvik TomasLudvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @stanoMilan, nice job, thank you!

s3tezsky
s3tezsky suggested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@s3tezsky s3tezsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the target to 9.1 instead of master 🙏

@stanoMilan stanoMilan changed the base branch from master to 9.1 January 28, 2021 09:21
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TomasLudvik TomasLudvik merged commit e634dc6 into shopsys:9.1 Feb 2, 2021
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@sslt sslt sslt approved these changes

@s3tezsky s3tezsky s3tezsky approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Easy Pick Not tricky or complex issue
Projects
None yet
Milestone
SSFW 9.1.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stanoMilan @grossmannmartin @TomasLudvik @sslt @s3tezsky @msshopsys