Skip to content

Commit

Permalink
Merge branch 'next-11486/product-card-border-cut-off-from-the-left' i…
Browse files Browse the repository at this point in the history
…nto 'trunk'

NEXT-11486 - Product card border cut off from the left in a product slider

See merge request shopware/6/product/platform!7255
  • Loading branch information
pweyck committed Jan 25, 2022
2 parents 38608db + 4aca56a commit bf4d022
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
@@ -0,0 +1,6 @@
---
title: Product card border cut off from the left in a product slider.
issue: NEXT-11486
---
# Storefront
* Set overflow of tns-ovh to visible and set overflow of base-slider to hidden
Expand Up @@ -8,6 +8,7 @@ based on: https://github.com/ganlanyuan/tiny-slider

.base-slider {
position: relative;
overflow: hidden;

// styling works both for auto generated markup by the tiny-slider and normal template markup
.tns-nav,
Expand Down Expand Up @@ -53,6 +54,10 @@ based on: https://github.com/ganlanyuan/tiny-slider
padding-left: 25px;
padding-right: 25px;
}

.tns-ovh {
overflow: visible;
}
}

.base-slider-controls {
Expand Down Expand Up @@ -88,7 +93,7 @@ based on: https://github.com/ganlanyuan/tiny-slider
border: 0;
background: none;
}

&[disabled] {
opacity: 0.2;
cursor: default;
Expand Down

2 comments on commit bf4d022

@moorl
Copy link

@moorl moorl commented on bf4d022 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Navigation dots outside are hidden now
  • If the navigation arrows are used outside, I can see the border of previous/next products

@mitelg
Copy link
Member

@mitelg mitelg commented on bf4d022 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @moorl
thanks for the hints. could you please create issues for that, as comments on commits are easily overlooked.

Please sign in to comment.