Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin - Theme #101

Closed
dahormez opened this issue Jul 22, 2019 · 2 comments
Closed

Plugin - Theme #101

dahormez opened this issue Jul 22, 2019 · 2 comments
Assignees
@jenskueper

Comments

@dahormez
Copy link
Contributor

dahormez commented Jul 22, 2019 •
edited
Loading

Hello,

  • Plugin Theme uninstall does not remove the theme from storefront and admin view. (would be great for completly re-apply theme config or something)

  • Theme configuration custom logos in dist folder can only installed once:
    Message: A file with the name "logo.x" already exists.
    On a new install, you cant apply the theme.json again - force command?!

  • the documentation say, place theme.json under resources, but it should be placed under src

Cheers :-)!
@jenskueper jenskueper self-assigned this Jul 22, 2019
@jenskueper
Copy link
Contributor

Hello!

These are all three valid issues! We are currently working on a theme system update and these issues will be addressed.

Best regards,
Jens

@jenskueper
Copy link
Contributor

Hey dahormez,

with the EA1.1 release we have fixed these and a couple of other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenskueper jenskueper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenskueper @dahormez