Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 2029 - Fix placeholderVisible state depending on isEmpty on mode switch #2048

Closed
wants to merge 2 commits into from

Conversation

r4pt0s
Copy link
Contributor

@r4pt0s r4pt0s commented Sep 3, 2021

1. Why is this change necessary?

To provide a meaningful user experience with expected behaviour for merchants.

2. What does this change do, exactly?

It updates the placeholderVisible state properly depending on mode switch (code editor mode => text editor mode)

3. Describe each step to reproduce the issue or behaviour.

See issue nr #2029

4. Please link to the relevant issues (if any).

#2029

5. Checklist

  • I have written tests and verified that they fail without my change
  • [ X] I have squashed any insignificant commits
  • [X ] I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • [ X] I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2021

CLA assistant check
All committers have signed the CLA.

@NiklasLimberg NiklasLimberg self-assigned this Sep 3, 2021
@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-17045

Please use this issue to track the state of your pull request.

@NiklasLimberg
Copy link
Contributor

Thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants