Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate option "stock" to "Apply Standard Data" #2168

Closed
wants to merge 1 commit into from

Conversation

@tsia
Copy link
Contributor

commented Aug 2, 2019

1. Why is this change necessary?

When using "Apply Standard Data" the stock value of all variants gets overwritten. I can't think of a case where this is intended.

2. What does this change do, exactly?

add another option to sync stock to all variants if someone needs it
exclude stock syncing when syncing the "settings" section

3. Describe each step to reproduce the issue or behaviour.

open article with multiple variants. each variant has a different stock (reflecting the current situation in the warehouse)
change setting (for example enable "last stock")
use the "Apply Standard Data" feature
stock for all variants is now the same

4. Please link to the relevant issues (if any).

https://issues.shopware.com/issues/SW-24189
https://issues.shopware.com/issues/SW-21371

5. Which documentation changes (if any) need to be made because of this PR?

explain the additional option in the "Apply Standard Data" dialog

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.
@shyim

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Hey,
can you squash your commits and target the branch 5.6?

@tsia tsia changed the base branch from 5.3 to 5.6 Aug 5, 2019

@tsia tsia force-pushed the tsia:5.3 branch from 6433138 to a9b8e54 Aug 5, 2019

@tsia

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

sorry. fixed it

@shopwareBot

This comment has been minimized.

Copy link

commented Aug 5, 2019

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-24390

Please use this issue to track the state of your pull request.

shopwareBot pushed a commit that referenced this pull request Aug 13, 2019

Merge pull request #7959 in SW/shopware from sw-24390/5.6/auto-import…
…ed-from-github to github-prs

* commit '1d35fcdae0a88b3aa164a270f81c02a7d5490dcb':
  Sw-24390 - Fixed snippets, window height and UPGRADE.md
  SW-24390 - Add separate option "stock" to "Apply Standard Data" fixes #2168
@shyim

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Thanks for your Contribution! 💙

@shyim shyim closed this Aug 13, 2019

@shyim shyim added Accepted and removed Quick-Pick Scheduled labels Aug 13, 2019

shopwareBot pushed a commit that referenced this pull request Aug 16, 2019

Merge pull request #7995 in SW/shopware from ntr/5.6/github-merge to 5.6
* commit '343568706cd090ea4d256cac050d2e4e7299376e': (30 commits)
  NTR - Fix code style
  SW-19930 - Fix snippets module pagesize
  SW-24440 - Fix wrong scope in cookie plugin which results in an error when switching the viewport
  SW-23620 - Update UPGRADE.md
  NTR - Allow container extensions
  SW-23620 - Countries with attributes fixes #2032
  SW-24423 - Fix mobile menu in content types
  SW-24428 - Fix custom http response codes in api
  SW-24430 - Fix double smarty block
  NTR - Fix commit hook for Enlight files
  SW-24400 - Updated UPGRADE.md
  SW-24400 - Fix PT-9148 fixes #2171
  NTR - Fix unsafe unserialize occurences
  NTR - Fix compiler pass LegacyApiResourcesPass
  SW-24432 - Fix snippet in blog module
  SW-24384 - Fix cart restoring when customer logouts
  Sw-24390 - Fixed snippets, window height and UPGRADE.md
  SW-24390 - Add separate option "stock" to "Apply Standard Data" fixes #2168
  SW-24376 - Reset filters on the detail page since we're using a global store
  SW-24420 - Prevent numeric field labels
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.