Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PT-9148 #2171

Closed
wants to merge 1 commit into from

Conversation

@aherking
Copy link
Contributor

commented Aug 6, 2019

Don't know why there is a +1 - deleting it solves the exception when selection the 31th of a month.

1. Why is this change necessary?

Sovles exception

2. What does this change do, exactly?

Does not add +1

3. Describe each step to reproduce the issue or behaviour.

Go to affilate marketing, select a range of 01.03.2018 to 31.07.2018, and clock on Download - you will get an expcetion with an invalid date (2018-08-32)

4. Please link to the relevant issues (if any).

https://issues.shopware.com/issues/PT-9148

5. Which documentation changes (if any) need to be made because of this PR?

No.

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.
@shopwareBot

This comment has been minimized.

Copy link

commented Aug 7, 2019

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-24400

Please use this issue to track the state of your pull request.

shopwareBot pushed a commit that referenced this pull request Aug 14, 2019
shopwareBot pushed a commit that referenced this pull request Aug 14, 2019
Merge pull request #7968 in SW/shopware from sw-24400/5.6/auto-import…
…ed-from-github to github-prs

* commit 'b455197eed22c97f89860832b568a9e1491208f1':
  SW-24400 - Updated UPGRADE.md
  SW-24400 - Fix PT-9148 fixes #2171

@shyim shyim added Accepted and removed Quick-Pick Scheduled labels Aug 14, 2019

@shyim

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thanks for your Contribution! 💙

@shyim shyim closed this Aug 14, 2019

shopwareBot pushed a commit that referenced this pull request Aug 16, 2019
Merge pull request #7995 in SW/shopware from ntr/5.6/github-merge to 5.6
* commit '343568706cd090ea4d256cac050d2e4e7299376e': (30 commits)
  NTR - Fix code style
  SW-19930 - Fix snippets module pagesize
  SW-24440 - Fix wrong scope in cookie plugin which results in an error when switching the viewport
  SW-23620 - Update UPGRADE.md
  NTR - Allow container extensions
  SW-23620 - Countries with attributes fixes #2032
  SW-24423 - Fix mobile menu in content types
  SW-24428 - Fix custom http response codes in api
  SW-24430 - Fix double smarty block
  NTR - Fix commit hook for Enlight files
  SW-24400 - Updated UPGRADE.md
  SW-24400 - Fix PT-9148 fixes #2171
  NTR - Fix unsafe unserialize occurences
  NTR - Fix compiler pass LegacyApiResourcesPass
  SW-24432 - Fix snippet in blog module
  SW-24384 - Fix cart restoring when customer logouts
  Sw-24390 - Fixed snippets, window height and UPGRADE.md
  SW-24390 - Add separate option "stock" to "Apply Standard Data" fixes #2168
  SW-24376 - Reset filters on the detail page since we're using a global store
  SW-24420 - Prevent numeric field labels
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.