Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Controller - Handle sessionKey correctly in isShippingRequest() #2203

Conversation

@screeny05
Copy link
Member

commented Sep 19, 2019

1. Why is this change necessary?

The correct separator for sessionKey is , not ;

2. What does this change do, exactly?

Change the separator in the explode-call

3. Describe each step to reproduce the issue or behaviour.

  1. In the shop you should have two countries active. One of which should not be available for shipping.
  2. Create a new account (no alternative shipping-address)
  3. Add a new address with the non-shipping-country selected
  4. Go to the checkout
  5. Open the modal for editing the current address (which is both shipping & billing)
  6. The non-shipping-country is selectable, even though according to the template file it shouldn't be, as this should be a shippingRequest but isn't.

This happens because in the template-files and the Shopware_Controller_Frontend_Address:handleExtraData()-function the sessionKey is separated by a ,. Only the isShippingRequest()-function handles this wrong.

4. Please link to the relevant issues (if any).

None

5. Which documentation changes (if any) need to be made because of this PR?

None

6. Checklist

  • I have squashed any insignificant commits
  • I have read the contribution requirements and fulfil them.
@shopwareBot

This comment has been minimized.

Copy link

commented Sep 19, 2019

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-24616

Please use this issue to track the state of your pull request.

@shyim

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

Thanks for your Contribution! 💙

@shyim shyim closed this Sep 30, 2019
@shyim shyim added Accepted and removed Quick-Pick Scheduled labels Sep 30, 2019
shopwareBot pushed a commit that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.