New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log entry table to allow longer messages #2394
Update log entry table to allow longer messages #2394
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #2394 +/- ##
==========================================
- Coverage 62.74% 62.70% -0.04%
==========================================
Files 3317 3318 +1
Lines 72266 72353 +87
==========================================
+ Hits 45344 45370 +26
- Misses 26922 26983 +61
Continue to review full report at Codecov.
|
80f9ec2
to
9c7b7f0
Compare
@@ -0,0 +1,52 @@ | |||
<?php | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't use any file headers
src/Core/Migration/Test/Migration1647443222AllowLongLogEntryMessagesTest.php
Show resolved
Hide resolved
9c7b7f0
to
bc9cd3a
Compare
You also need to change the field type inside the definition |
Add test and update changelog Enhance test Remove migration update Fix linting issues Apply review suggestions Update definition
bc9cd3a
to
cf20f90
Compare
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
Thanks @maximilianruesch for contributing! 🎉 |
1. Why is this change necessary?
Long messages in log entries (such as stack traces) which exceed 255 characters cannot be saved in the database. The creation of the row fails, as the data is too large to fit in the data cell. See the example below.
2. What does this change do, exactly?
This PR changes the datatype of the column
message
in the tablelog_entry
fromVARCHAR(255)
toLONGTEXT
, effectively removing the character limit. The "limit" now sits at roughly 4GB, which should be enough for even the longest stack traces.3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist
Small example for the kind of error message