From 3206230d29ad61f4c8d63f4e9f79910eeea28763 Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Fri, 8 May 2026 16:16:46 -0700 Subject: [PATCH] ci(shorebird): use framework.zip as macos-framework src (xcframework, not single-arch) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit create_macos_framework.py with --zip produces two outputs in dst/: - FlutterMacOS.framework.zip — single-arch, double-zipped framework (~17 MB) - framework.zip — the xcframework (both arm64 + x64) plus codesign config files (entitlements.txt, without_entitlements.txt, unsigned_binaries.txt) (~122 MB) Legacy mac_upload.sh uploads framework.zip (the xcframework). Compose was uploading the single-arch FlutterMacOS.framework.zip and renaming it to framework.zip in the bucket via the dst path — same name on disk, completely different bytes. Verified by bucket-comparing engine 93865d602479 (sharded, post-#150) against legacy 25c9b21d638f at the same darwin-x64-release/framework.zip path: 17,237,143 bytes vs 121,918,469 bytes. After this lands, the sharded artifact at that path should be the xcframework matching legacy in size and contents. --- shorebird/ci/compose.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shorebird/ci/compose.json b/shorebird/ci/compose.json index 7e25d3fc65540..5cda861198e33 100644 --- a/shorebird/ci/compose.json +++ b/shorebird/ci/compose.json @@ -22,7 +22,7 @@ "--x64-out-dir": "mac_release" }, "artifacts": [ - {"src": "FlutterMacOS.framework.zip", "dst": "flutter_infra_release/flutter/$engine/darwin-x64-release/framework.zip"}, + {"src": "framework.zip", "dst": "flutter_infra_release/flutter/$engine/darwin-x64-release/framework.zip"}, {"src": "FlutterMacOS.framework.dSYM.zip", "dst": "flutter_infra_release/flutter/$engine/darwin-x64/FlutterMacOS.framework.dSYM.zip"} ] },