Add peer_names attribute to volumes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for bricks to be added up correctly, the chef node names must be the same as the FQDN. This is not always the case. Adding the `peer_names` attribute allows for the Chef node names to be something other than the FQDN.
jking916
added a commit
that referenced
this pull request
Jul 9, 2015
Add peer_names attribute to volumes
|
Cool. I was working on this too. My plan was a bit different. I was using Chef::Node.load and looking up fqdn instead. Would you rather keep your work as is, or should I keep working on it? I have a work in progress here (with some conflated stuff that's in different PRs) here : https://github.com/jdblack/chef-gluster/tree/disambiguate_nodename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for bricks to be added up correctly, the chef node names must be the same as the FQDN. This is not always the case. Adding the
peer_namesattribute allows for the Chef node names to be something other than the FQDN.