New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hostname for older versions of chef-server #17

Merged
merged 3 commits into from Aug 10, 2015

Conversation

Projects
None yet
3 participants
@philbrookes

philbrookes commented Aug 5, 2015

Hey,

Excellent cookbook!

just a few minor tweaks:
On older versions of chef-server node['fqdn'] does not seem to be set:

chef > node['fqdn']
 => nil

This change will allow those older ones to use this cookbook and check against hostname instead, if fqdn fails for some reason.

I also slightly modified one of the error messages, when I was trying to debug an issue I was having :)

Show outdated Hide outdated recipes/server_setup.rb Outdated
@philbrookes

This comment has been minimized.

Show comment
Hide comment
@philbrookes

philbrookes Aug 6, 2015

Whoops, my mistake, I had changed the wrong if statement.

I've moved it to the correct one now.

philbrookes commented Aug 6, 2015

Whoops, my mistake, I had changed the wrong if statement.

I've moved it to the correct one now.

@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Aug 6, 2015

Thanks for reverting this back. However, i like the idea of the more verbose warning message you added below. Can you update this one too to output the brick_count and volume_values['replica_count']?

shortdudey123 commented on recipes/server_setup.rb in 9b088f3 Aug 6, 2015

Thanks for reverting this back. However, i like the idea of the more verbose warning message you added below. Can you update this one too to output the brick_count and volume_values['replica_count']?

@philbrookes

This comment has been minimized.

Show comment
Hide comment
@philbrookes

philbrookes Aug 6, 2015

cool, good idea. I've added that too.

philbrookes commented Aug 6, 2015

cool, good idea. I've added that too.

shortdudey123 added a commit that referenced this pull request Aug 10, 2015

Merge pull request #17 from philbrookes/fqdn-or-hostname
allow hostname for older versions of chef-server

@shortdudey123 shortdudey123 merged commit b2147f3 into shortdudey123:master Aug 10, 2015

@kareiva

This comment has been minimized.

Show comment
Hide comment
@kareiva

kareiva Aug 11, 2015

Contributor

👍

Contributor

kareiva commented Aug 11, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment