New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add owner/group/mode settings to gluster_mount LWRP #42

Merged
merged 4 commits into from Oct 19, 2015

Conversation

Projects
None yet
2 participants
@joyofhex
Contributor

joyofhex commented Oct 19, 2015

I've also added a small amount of documentation describing the available options.

@joyofhex

This comment has been minimized.

Show comment
Hide comment
@joyofhex

joyofhex Oct 19, 2015

Contributor

Hmm. I'm not positive that I even need the conditionals here. Removing them would fix this rubocop check, and seems to continue to work. However, I'm not confident that is correct chef code. Will do some more testing and push an extra change later.

Contributor

joyofhex commented Oct 19, 2015

Hmm. I'm not positive that I even need the conditionals here. Removing them would fix this rubocop check, and seems to continue to work. However, I'm not confident that is correct chef code. Will do some more testing and push an extra change later.

@joyofhex

This comment has been minimized.

Show comment
Hide comment
@joyofhex

joyofhex Oct 19, 2015

Contributor

After checking with folks who understand chef much more than me I now think I can remove these guard conditionals (as these default to nil and that is the same default in the chef directory resource). Pushed that.

Contributor

joyofhex commented Oct 19, 2015

After checking with folks who understand chef much more than me I now think I can remove these guard conditionals (as these default to nil and that is the same default in the chef directory resource). Pushed that.

Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Oct 19, 2015

Owner

Looks good other than the comments above, thanks!

Owner

shortdudey123 commented Oct 19, 2015

Looks good other than the comments above, thanks!

@joyofhex

This comment has been minimized.

Show comment
Hide comment
@joyofhex

joyofhex Oct 19, 2015

Contributor

Thanks for catching those. Updated the PR.

Contributor

joyofhex commented Oct 19, 2015

Thanks for catching those. Updated the PR.

shortdudey123 added a commit that referenced this pull request Oct 19, 2015

Merge pull request #42 from joyofhex/mount_owner
add owner/group/mode settings to gluster_mount LWRP

@shortdudey123 shortdudey123 merged commit ae1d6b7 into shortdudey123:master Oct 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joyofhex joyofhex deleted the joyofhex:mount_owner branch Oct 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment