New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added debian support #48

Merged
merged 3 commits into from Nov 25, 2015

Conversation

Projects
None yet
3 participants
@tomzo
Contributor

tomzo commented Nov 20, 2015

When on debian install packages from official glusterfs repository.
Tested debian as a client

added debian support
When on debian install packages from official glusterfs repository
Show outdated Hide outdated recipes/repository.rb Outdated
Show outdated Hide outdated recipes/repository.rb Outdated
@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Nov 20, 2015

Owner

Can you add the versions of debian that you have tested this on to the readme? will merged after that

Owner

shortdudey123 commented Nov 20, 2015

Can you add the versions of debian that you have tested this on to the readme? will merged after that

@Seth-Karlo

This comment has been minimized.

Show comment
Hide comment
@Seth-Karlo

Seth-Karlo Nov 21, 2015

Collaborator

Please also add Debian to the kitchen.yml file

Collaborator

Seth-Karlo commented Nov 21, 2015

Please also add Debian to the kitchen.yml file

@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Nov 21, 2015

Owner

That too
@Seth-Karlo i think that will cause merge conflicts for your PR so you probably will need to work w/ that assuming this gets merged first

Owner

shortdudey123 commented Nov 21, 2015

That too
@Seth-Karlo i think that will cause merge conflicts for your PR so you probably will need to work w/ that assuming this gets merged first

@tomzo

This comment has been minimized.

Show comment
Hide comment
@tomzo

tomzo Nov 21, 2015

Contributor

I can add it to readme, but I do not use vagrant+virtualbox for testing. So I would not be able to verify if tests in kitchen are actually worth anything.

Contributor

tomzo commented Nov 21, 2015

I can add it to readme, but I do not use vagrant+virtualbox for testing. So I would not be able to verify if tests in kitchen are actually worth anything.

@Seth-Karlo

This comment has been minimized.

Show comment
Hide comment
@Seth-Karlo

Seth-Karlo Nov 25, 2015

Collaborator

@shortdudey123 I don't think this will cause any merge conflicts, it's all new code. But if it causes an issue I will fix it.

Collaborator

Seth-Karlo commented Nov 25, 2015

@shortdudey123 I don't think this will cause any merge conflicts, it's all new code. But if it causes an issue I will fix it.

@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123
Owner

shortdudey123 commented Nov 25, 2015

shortdudey123 added a commit that referenced this pull request Nov 25, 2015

@shortdudey123 shortdudey123 merged commit 0067411 into shortdudey123:master Nov 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment