New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull req for biola 1 #9

Merged
merged 3 commits into from Apr 24, 2015

Conversation

Projects
None yet
2 participants
@bjozet
Contributor

bjozet commented Apr 24, 2015

This fixes a quotation-problem in bash-code-snippet where variables weren't properly expanded and also adds a "servicename" which is used to determine what the actual service is called on different dists. For example, in RHEL/CentOS the service is named "glustered". In Debian/Ubuntu it's "glusterfs-server"
(I also reverted my previous default-version-bump to 3.4, that added by mistake).

bjozet added some commits Apr 24, 2015

Variable in bash-code does not expand if enclosed in single-quotes,
replaced them with double-quotes to get proper variable expansion.
Created a "servicename" so that the service-hook actually starts the
correctly named service. In CentOS/RHEL it's called "glusterd", but in
ubuntu/debian it's called "glusterfs-server".

Added/moved some comments that was missing/malplaced.

jaredk-beta added a commit that referenced this pull request Apr 24, 2015

@jaredk-beta jaredk-beta merged commit e465f30 into shortdudey123:master Apr 24, 2015

@bjozet bjozet deleted the bjozet:pull-req-for-biola-1 branch May 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment