-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 3.2 support (Sourcery refactored) #160
Conversation
c399f21
to
b6fa64b
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.57%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
func.url_path = url_path if url_path else func.__name__ | ||
func.url_name = url_name if url_name else func.__name__.replace("_", "-") | ||
func.url_path = url_path or func.__name__ | ||
func.url_name = url_name or func.__name__.replace("_", "-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function action.decorator
refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity
)
elif isinstance(route, DynamicRoute) and not route.detail: | ||
elif isinstance(route, DynamicRoute): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function SimpleRouter.get_routes
refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if
)
bound_methods = {} | ||
for method, action in method_map.items(): | ||
if hasattr(viewset, action): | ||
bound_methods[method] = action | ||
return bound_methods | ||
return { | ||
method: action | ||
for method, action in method_map.items() | ||
if hasattr(viewset, action) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function SimpleRouter.get_method_map
refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension
) - Inline variable that is immediately returned (
inline-immediately-returned-variable
)
found = False | ||
for line in lines: | ||
if statement in line: | ||
found = True | ||
found = any(statement in line for line in lines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function TestUpgrade.test_sql
refactored with the following changes:
- Use any() instead of for loop (
use-any
)
Pull Request #159 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
dj3.2
branch, then run: