For SG-6337 - Add validation for username/password for Oxygen #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 1, 2018
| ERR_AUTH = 102 # error code for authentication related problems | ||
| ERR_2FA = 106 # error code when 2FA authentication is required but no 2FA token provided. | ||
| ERR_SSO = 108 # error code when SSO is activated on the site, preventing the use of username/password for authentication. | ||
| ERR_OXYG = 110 # error code when Oxygen is activated on the site, preventing the use of username/password for authentication. |
There was a problem hiding this comment.
at least two spaces before inline comment
| """ | ||
| pass | ||
|
|
||
| class UserCredentialsNotAllowedForOxygenAuthenticationFault(Fault): |
Pull Request Test Coverage Report for Build 926
💛 - Coveralls |
patrick-hubert-adsk
requested changes
Jun 1, 2018
Contributor
patrick-hubert-adsk
left a comment
patrick-hubert-adsk
left a comment
There was a problem hiding this comment.
Just validate that the HoundCI-Bot warnings can be addressed... Looks good otherwise.
patrick-hubert-adsk
approved these changes
Jun 1, 2018
Contributor
patrick-hubert-adsk
left a comment
patrick-hubert-adsk
left a comment
There was a problem hiding this comment.
HoundCI-Bot warnings are waived. I approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.