mimetypes.py: fix incompatibility with python3 due to old 'print' keyword and exception 'comma' syntax #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord syntax into the newer 'print' function syntax, also changing one try-except catching from the old 'comma' syntax to the newer 'as' keyword syntax
Contributor
|
We're dropping support for Python 2. This module will be removed in the future. We appreciate your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing print statements from the old py2 'print' keyword syntax into the newer 'print' function syntax, also changing one try-except exception catching from the old 'comma' syntax to the newer 'as' keyword syntax. Now this module can be imported in both python3 and python2 safely, prior to that it was not compatible with python3.
Note: the 'as' assignment within an exception catching is not compatible with python <= 2.5 but it is better to have this module compatible with python3 than with python <= 2.5 (https://peps.python.org/pep-3110/)