Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraConnection: Replace generic codec with direct usage of CassandraCodec #766

Merged
merged 1 commit into from Aug 29, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 29, 2022

There is no advantage to using generics here as CassandraConnection will only ever be used with a CassandraCodec so we should directly use CassandraCodec to improve code readability.

Copy link
Member

@conorbros conorbros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, pretty sure this was me. Good catch.

@github-actions
Copy link

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/2945602356

Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe
transform/redis_timestamp_tagger_tagged
                        time:   [1.9117 us 1.9400 us 1.9679 us]
                        change: [+22.926% +25.648% +28.354%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai rukai requested a review from benbromhead August 29, 2022 08:09
@rukai rukai merged commit 4104d95 into shotover:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants